diff options
author | Chandler Carruth <chandlerc@gmail.com> | 2014-01-12 11:30:46 +0000 |
---|---|---|
committer | Chandler Carruth <chandlerc@gmail.com> | 2014-01-12 11:30:46 +0000 |
commit | 9d805139bdf016787c4d66619b17a2fff2c5392c (patch) | |
tree | 22e3dadb68961cff98013382789a4c3549d797a8 /llvm/lib/IR/IRPrintingPasses.cpp | |
parent | 3dd261d0c94d949b75e82cd581a0b5cd50aee9b6 (diff) | |
download | bcm5719-llvm-9d805139bdf016787c4d66619b17a2fff2c5392c.tar.gz bcm5719-llvm-9d805139bdf016787c4d66619b17a2fff2c5392c.zip |
[PM] Simplify the interface exposed for IR printing passes.
Nothing was using the ability of the pass to delete the raw_ostream it
printed to, and nothing was trying to pass it a pointer to the
raw_ostream. Also, the function variant had a different order of
arguments from all of the others which was just really confusing. Now
the interface accepts a reference, doesn't offer to delete it, and uses
a consistent order. The implementation of the printing passes haven't
been updated with this simplification, this is just the API switch.
llvm-svn: 199044
Diffstat (limited to 'llvm/lib/IR/IRPrintingPasses.cpp')
-rw-r--r-- | llvm/lib/IR/IRPrintingPasses.cpp | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/llvm/lib/IR/IRPrintingPasses.cpp b/llvm/lib/IR/IRPrintingPasses.cpp index 4398a9cfd2a..242dcff795b 100644 --- a/llvm/lib/IR/IRPrintingPasses.cpp +++ b/llvm/lib/IR/IRPrintingPasses.cpp @@ -113,20 +113,17 @@ char PrintBasicBlockPass::ID = 0; INITIALIZE_PASS(PrintBasicBlockPass, "print-bb", "Print BB to stderr", false, false) -ModulePass *llvm::createPrintModulePass(llvm::raw_ostream *OS, - bool DeleteStream, +ModulePass *llvm::createPrintModulePass(llvm::raw_ostream &OS, const std::string &Banner) { - return new PrintModulePass(Banner, OS, DeleteStream); + return new PrintModulePass(Banner, &OS, false); } -FunctionPass *llvm::createPrintFunctionPass(const std::string &Banner, - llvm::raw_ostream *OS, - bool DeleteStream) { - return new PrintFunctionPass(Banner, OS, DeleteStream); +FunctionPass *llvm::createPrintFunctionPass(llvm::raw_ostream &OS, + const std::string &Banner) { + return new PrintFunctionPass(Banner, &OS, false); } -BasicBlockPass *llvm::createPrintBasicBlockPass(llvm::raw_ostream *OS, - bool DeleteStream, +BasicBlockPass *llvm::createPrintBasicBlockPass(llvm::raw_ostream &OS, const std::string &Banner) { - return new PrintBasicBlockPass(Banner, OS, DeleteStream); + return new PrintBasicBlockPass(Banner, &OS, false); } |