diff options
| author | Zachary Turner <zturner@google.com> | 2018-07-06 21:01:42 +0000 |
|---|---|---|
| committer | Zachary Turner <zturner@google.com> | 2018-07-06 21:01:42 +0000 |
| commit | 648bebdc67f6dffa7de4b7bfe028498357ebf74d (patch) | |
| tree | 61124208eab6f417f30602de6fb94b06ee47bb45 /llvm/lib/IR/DebugInfoMetadata.cpp | |
| parent | 975c711358a1b91d9feba2200d1d85c2cc8cbd87 (diff) | |
| download | bcm5719-llvm-648bebdc67f6dffa7de4b7bfe028498357ebf74d.tar.gz bcm5719-llvm-648bebdc67f6dffa7de4b7bfe028498357ebf74d.zip | |
[PDB] One more fix for hasing GSI records.
The reference implementation uses a case-insensitive string
comparison for strings of equal length. This will cause the
string "tEo" to compare less than "VUo". However we were using
a case sensitive comparison, which would generate the opposite
outcome. Switch to a case insensitive comparison. Also, when
one of the strings contains non-ascii characters, fallback to
a straight memcmp.
The only way to really test this is with a DIA test. Before this
patch, the test will fail (but succeed if link.exe is used instead
of lld-link). After the patch, it succeeds even with lld-link.
llvm-svn: 336464
Diffstat (limited to 'llvm/lib/IR/DebugInfoMetadata.cpp')
0 files changed, 0 insertions, 0 deletions
