diff options
author | Lang Hames <lhames@gmail.com> | 2018-08-18 02:06:18 +0000 |
---|---|---|
committer | Lang Hames <lhames@gmail.com> | 2018-08-18 02:06:18 +0000 |
commit | 76e21c9792ce2abf7a2ba019073bfd0fe1b4134b (patch) | |
tree | c280af12181fc06e545dd8c8b92c9d577b9e7efc /llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp | |
parent | 0ac54fad538eabd9b368f6e2460898621828a72b (diff) | |
download | bcm5719-llvm-76e21c9792ce2abf7a2ba019073bfd0fe1b4134b.tar.gz bcm5719-llvm-76e21c9792ce2abf7a2ba019073bfd0fe1b4134b.zip |
[ORC] Rename 'finalize' to 'emit' to avoid potential confusion.
An emitted symbol has had its contents written and its memory protections
applied, but it is not automatically ready to execute.
Prior to ORC supporting concurrent compilation, the term "finalized" could be
interpreted two different (but effectively equivalent) ways: (1) The finalized
symbol's contents have been written and its memory protections applied, and (2)
the symbol is ready to run. Now that ORC supports concurrent compilation, sense
(1) no longer implies sense (2). We have already introduced a new term, 'ready',
to capture sense (2), so rename sense (1) to 'emitted' to avoid any lingering
confusion.
llvm-svn: 340115
Diffstat (limited to 'llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp')
-rw-r--r-- | llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp b/llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp index 3ceafc25eec..1dfa90acb76 100644 --- a/llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp +++ b/llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp @@ -80,10 +80,10 @@ namespace orc { RTDyldObjectLinkingLayer2::RTDyldObjectLinkingLayer2( ExecutionSession &ES, GetMemoryManagerFunction GetMemoryManager, - NotifyLoadedFunction NotifyLoaded, NotifyFinalizedFunction NotifyFinalized) + NotifyLoadedFunction NotifyLoaded, NotifyEmittedFunction NotifyEmitted) : ObjectLayer(ES), GetMemoryManager(GetMemoryManager), NotifyLoaded(std::move(NotifyLoaded)), - NotifyFinalized(std::move(NotifyFinalized)), ProcessAllSections(false) {} + NotifyEmitted(std::move(NotifyEmitted)), ProcessAllSections(false) {} void RTDyldObjectLinkingLayer2::emit(MaterializationResponsibility R, VModuleKey K, @@ -157,10 +157,10 @@ void RTDyldObjectLinkingLayer2::emit(MaterializationResponsibility R, return; } - R.finalize(); + R.emit(); - if (NotifyFinalized) - NotifyFinalized(K); + if (NotifyEmitted) + NotifyEmitted(K); } void RTDyldObjectLinkingLayer2::mapSectionAddress( |