diff options
author | Filip Pizlo <fpizlo@apple.com> | 2013-10-02 00:59:25 +0000 |
---|---|---|
committer | Filip Pizlo <fpizlo@apple.com> | 2013-10-02 00:59:25 +0000 |
commit | 7aa695e0265727af08932d555d2303463eb8c17a (patch) | |
tree | 3af213e64b510f1ea8a37c0d1b7d3a48aa891606 /llvm/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp | |
parent | f2dd4ef157a054301337d44edda3a1f3c2f4d8f9 (diff) | |
download | bcm5719-llvm-7aa695e0265727af08932d555d2303463eb8c17a.tar.gz bcm5719-llvm-7aa695e0265727af08932d555d2303463eb8c17a.zip |
This threads SectionName through the allocateCodeSection/allocateDataSection APIs, both in C++ and C land.
It's useful for the memory managers that are allocating a section to know what the name of the section is.
At a minimum, this is useful for low-level debugging - it's customary for JITs to be able to tell you what
memory they allocated, and as part of any such dump, they should be able to tell you some meta-data about
what each allocation is for. This allows clients that supply their own memory managers to do this.
Additionally, we also envision the SectionName being useful for passing meta-data from within LLVM to an LLVM
client.
This changes both the C and C++ APIs, and all of the clients of those APIs within LLVM. I'm assuming that
it's safe to change the C++ API because that API is allowed to change. I'm assuming that it's safe to change
the C API because we haven't shipped the API in a release yet (LLVM 3.3 doesn't include the MCJIT memory
management C API).
llvm-svn: 191804
Diffstat (limited to 'llvm/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp')
-rw-r--r-- | llvm/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/llvm/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp b/llvm/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp index 5469c8374b1..cf90e77e389 100644 --- a/llvm/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp +++ b/llvm/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp @@ -19,9 +19,10 @@ namespace llvm { uint8_t *SectionMemoryManager::allocateDataSection(uintptr_t Size, - unsigned Alignment, - unsigned SectionID, - bool IsReadOnly) { + unsigned Alignment, + unsigned SectionID, + StringRef SectionName, + bool IsReadOnly) { if (IsReadOnly) return allocateSection(RODataMem, Size, Alignment); return allocateSection(RWDataMem, Size, Alignment); @@ -29,7 +30,8 @@ uint8_t *SectionMemoryManager::allocateDataSection(uintptr_t Size, uint8_t *SectionMemoryManager::allocateCodeSection(uintptr_t Size, unsigned Alignment, - unsigned SectionID) { + unsigned SectionID, + StringRef SectionName) { return allocateSection(CodeMem, Size, Alignment); } |