summaryrefslogtreecommitdiffstats
path: root/llvm/lib/ExecutionEngine/JIT/JITMemoryManager.cpp
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2014-03-26 04:48:47 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2014-03-26 04:48:47 +0000
commit3b712a84a9bdcde4b6e8f8f8c9cace2fb3141f24 (patch)
treea4e87b48f5721320b1868077f42b0600921efdf7 /llvm/lib/ExecutionEngine/JIT/JITMemoryManager.cpp
parent62dd7df612d7eb4b118d3a6ed166c9e781ae6f82 (diff)
downloadbcm5719-llvm-3b712a84a9bdcde4b6e8f8f8c9cace2fb3141f24.tar.gz
bcm5719-llvm-3b712a84a9bdcde4b6e8f8f8c9cace2fb3141f24.zip
Prevent alias from pointing to weak aliases.
Aliases are just another name for a position in a file. As such, the regular symbol resolutions are not applied. For example, given define void @my_func() { ret void } @my_alias = alias weak void ()* @my_func @my_alias2 = alias void ()* @my_alias We produce without this patch: .weak my_alias my_alias = my_func .globl my_alias2 my_alias2 = my_alias That is, in the resulting ELF file my_alias, my_func and my_alias are just 3 names pointing to offset 0 of .text. That is *not* the semantics of IR linking. For example, linking in a @my_alias = alias void ()* @other_func would require the strong my_alias to override the weak one and my_alias2 would end up pointing to other_func. There is no way to represent that with aliases being just another name, so the best solution seems to be to just disallow it, converting a miscompile into an error. llvm-svn: 204781
Diffstat (limited to 'llvm/lib/ExecutionEngine/JIT/JITMemoryManager.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud