diff options
author | Nico Weber <nicolasweber@gmx.de> | 2019-04-18 19:52:32 +0000 |
---|---|---|
committer | Nico Weber <nicolasweber@gmx.de> | 2019-04-18 19:52:32 +0000 |
commit | a0ac65c98f2816f42432448eb3d23d1b7df5c06c (patch) | |
tree | cda950fec488e59afcca7f1b8e614774e1d32f74 /llvm/lib/Demangle | |
parent | 502cf4bd19f9aaf4c412de147912cd178fe40e20 (diff) | |
download | bcm5719-llvm-a0ac65c98f2816f42432448eb3d23d1b7df5c06c.tar.gz bcm5719-llvm-a0ac65c98f2816f42432448eb3d23d1b7df5c06c.zip |
llvm-undname: Fix two more asserts-on-invalid, found by oss-fuzz
llvm-svn: 358708
Diffstat (limited to 'llvm/lib/Demangle')
-rw-r--r-- | llvm/lib/Demangle/MicrosoftDemangle.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/llvm/lib/Demangle/MicrosoftDemangle.cpp b/llvm/lib/Demangle/MicrosoftDemangle.cpp index 13227381743..3fb8e0ec5c5 100644 --- a/llvm/lib/Demangle/MicrosoftDemangle.cpp +++ b/llvm/lib/Demangle/MicrosoftDemangle.cpp @@ -982,6 +982,7 @@ static uint8_t rebasedHexDigitToNumber(char C) { } uint8_t Demangler::demangleCharLiteral(StringView &MangledName) { + assert(!MangledName.empty()); if (!MangledName.startsWith('?')) return MangledName.popFront(); @@ -1248,7 +1249,7 @@ Demangler::demangleStringLiteral(StringView &MangledName) { // Encoded Length std::tie(StringByteSize, IsNegative) = demangleNumber(MangledName); - if (Error || IsNegative) + if (Error || IsNegative || StringByteSize < (IsWcharT ? 2 : 1)) goto StringLiteralError; // CRC 32 (always 8 characters plus a terminator) @@ -1269,7 +1270,7 @@ Demangler::demangleStringLiteral(StringView &MangledName) { Result->IsTruncated = true; while (!MangledName.consumeFront('@')) { - if (StringByteSize < 2) + if (MangledName.size() < 2) goto StringLiteralError; wchar_t W = demangleWcharLiteral(MangledName); if (StringByteSize != 2 || Result->IsTruncated) @@ -1286,7 +1287,7 @@ Demangler::demangleStringLiteral(StringView &MangledName) { unsigned BytesDecoded = 0; while (!MangledName.consumeFront('@')) { - if (StringByteSize < 1) + if (MangledName.size() < 1) goto StringLiteralError; StringBytes[BytesDecoded++] = demangleCharLiteral(MangledName); } |