diff options
author | Zachary Turner <zturner@google.com> | 2018-11-01 04:02:41 +0000 |
---|---|---|
committer | Zachary Turner <zturner@google.com> | 2018-11-01 04:02:41 +0000 |
commit | 56a5a0c3ce57da8c4c8def9f30b628bcb9a4f87f (patch) | |
tree | eeba8968219049c8ba6175238e29b0b1dd4997b0 /llvm/lib/DebugInfo | |
parent | 03170a904f5b5f7f6eb11db4b427c35180e29e2e (diff) | |
download | bcm5719-llvm-56a5a0c3ce57da8c4c8def9f30b628bcb9a4f87f.tar.gz bcm5719-llvm-56a5a0c3ce57da8c4c8def9f30b628bcb9a4f87f.zip |
[CodeView] Emit the correct TypeIndex for std::nullptr_t.
The TypeIndex used by cl.exe is 0x103, which indicates a SimpleTypeMode
of NearPointer (note the absence of the bitness, normally pointers use a
mode of NearPointer32 or NearPointer64) and a SimpleTypeKind of void.
So this is basically a void*, but without a specified size, which makes
sense given how std::nullptr_t is defined.
clang-cl was actually not emitting *anything* for this. Instead, when we
encountered std::nullptr_t in a DIType, we would actually just emit a
TypeIndex of 0, which is obviously wrong.
std::nullptr_t in DWARF is represented as a DW_TAG_unspecified_type with
a name of "decltype(nullptr)", so we add that logic along with a test,
as well as an update to the dumping code so that we no longer print
void* when dumping 0x103 (which would previously treat Void/NearPointer
no differently than Void/NearPointer64).
Differential Revision: https://reviews.llvm.org/D53957
llvm-svn: 345811
Diffstat (limited to 'llvm/lib/DebugInfo')
-rw-r--r-- | llvm/lib/DebugInfo/CodeView/TypeIndex.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/llvm/lib/DebugInfo/CodeView/TypeIndex.cpp b/llvm/lib/DebugInfo/CodeView/TypeIndex.cpp index 24fe5fcb28d..332d67470da 100644 --- a/llvm/lib/DebugInfo/CodeView/TypeIndex.cpp +++ b/llvm/lib/DebugInfo/CodeView/TypeIndex.cpp @@ -74,6 +74,9 @@ StringRef TypeIndex::simpleTypeName(TypeIndex TI) { if (TI.isNoneType()) return "<no type>"; + if (TI == TypeIndex::NullptrT()) + return "std::nullptr_t"; + // This is a simple type. for (const auto &SimpleTypeName : SimpleTypeNames) { if (SimpleTypeName.Kind == TI.getSimpleKind()) { |