diff options
| author | Krzysztof Pszeniczny <krzysztof.pszeniczny@gmail.com> | 2018-10-19 19:02:16 +0000 |
|---|---|---|
| committer | Krzysztof Pszeniczny <krzysztof.pszeniczny@gmail.com> | 2018-10-19 19:02:16 +0000 |
| commit | 2bfe759a8d7f4e544ac0f079d447f33c0b4dcf9c (patch) | |
| tree | 67b55e22e6a7f0754d8f43626ed25679dddf4488 /llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h | |
| parent | b3d203ff7f308cc5675f095654d0cda905bf95bf (diff) | |
| download | bcm5719-llvm-2bfe759a8d7f4e544ac0f079d447f33c0b4dcf9c.tar.gz bcm5719-llvm-2bfe759a8d7f4e544ac0f079d447f33c0b4dcf9c.zip | |
Fix a use-after-RAUW bug in large GEP splitting
Summary:
Large GEP splitting, introduced in rL332015, uses a `DenseMap<AssertingVH<Value>, ...>`. This causes an assertion to fail (in debug builds) or undefined behaviour to occur (in release builds) when a value is RAUWed.
This manifested itself in the 7zip benchmark from the llvm test suite built on ARM with `-fstrict-vtable-pointers` enabled while RAUWing invariant group launders and splits in CodeGenPrepare.
This patch merges the large offsets of the argument and the result of an invariant.group strip/launder intrinsic before RAUWing.
Reviewers: Prazek, javed.absar, haicheng, efriedma
Reviewed By: Prazek, efriedma
Subscribers: kristof.beyls, hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D51936
llvm-svn: 344802
Diffstat (limited to 'llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h')
0 files changed, 0 insertions, 0 deletions
