diff options
| author | Alexey Samsonov <samsonov@google.com> | 2013-04-09 14:09:42 +0000 |
|---|---|---|
| committer | Alexey Samsonov <samsonov@google.com> | 2013-04-09 14:09:42 +0000 |
| commit | d60859b21e02c320fdd851b31b787f646e11b882 (patch) | |
| tree | d15ddc67a36327a1472cb3ae22308d08c2672abb /llvm/lib/DebugInfo/DWARFFormValue.h | |
| parent | 9ca6e810b70994c147e960cb8179f7b9af7b61b9 (diff) | |
| download | bcm5719-llvm-d60859b21e02c320fdd851b31b787f646e11b882.tar.gz bcm5719-llvm-d60859b21e02c320fdd851b31b787f646e11b882.zip | |
DWARF parser: Fix DWARF-2/3 incompatibility: size of DW_FORM_ref_addr is the same as DW_FORM_addr in DWARF2, and is 4/8 bytes on 32/64-bit DWARF starting from DWARF3. Adding a test for this is a huge pain - generating and uploading pre-built binary with DWARF3 debug info is way too ugly, and writing fine-grained unittests for DebugInfo is impossible, as it doesn't expose any headers in include/llvm. That said, I'm going to choose the second approach and submit the patch exposing DebugInfo headers for review soon enough.
llvm-svn: 179095
Diffstat (limited to 'llvm/lib/DebugInfo/DWARFFormValue.h')
| -rw-r--r-- | llvm/lib/DebugInfo/DWARFFormValue.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/DebugInfo/DWARFFormValue.h b/llvm/lib/DebugInfo/DWARFFormValue.h index b863001e4af..eaaccfb4f33 100644 --- a/llvm/lib/DebugInfo/DWARFFormValue.h +++ b/llvm/lib/DebugInfo/DWARFFormValue.h @@ -74,7 +74,7 @@ public: uint32_t *offset_ptr, const DWARFCompileUnit *cu); static bool isBlockForm(uint16_t form); static bool isDataForm(uint16_t form); - static const uint8_t *getFixedFormSizesForAddressSize(uint8_t addr_size); + static const uint8_t *getFixedFormSizes(uint8_t AddrSize, uint16_t Version); }; } |
