diff options
| author | Chad Rosier <mcrosier@apple.com> | 2012-10-30 20:01:12 +0000 |
|---|---|---|
| committer | Chad Rosier <mcrosier@apple.com> | 2012-10-30 20:01:12 +0000 |
| commit | 86f6050c54c12ba87156a3b23134a03456b3d1a0 (patch) | |
| tree | cde7bfd90448d5fb0872935c61e54d10cac029fb /llvm/lib/CodeGen | |
| parent | 48a6478242fd28723a69802f7b46a588df85608b (diff) | |
| download | bcm5719-llvm-86f6050c54c12ba87156a3b23134a03456b3d1a0.tar.gz bcm5719-llvm-86f6050c54c12ba87156a3b23134a03456b3d1a0.zip | |
Add a comment for r167040.
llvm-svn: 167046
Diffstat (limited to 'llvm/lib/CodeGen')
| -rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp index eacba90f0ce..d6016d22fd1 100644 --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp @@ -6145,6 +6145,10 @@ void SelectionDAGBuilder::visitInlineAsm(ImmutableCallSite CS) { // Compute the constraint code and ConstraintType to use. TLI.ComputeConstraintToUse(OpInfo, SDValue()); + // Ideally, we would only check against memory constraints. However, the + // meaning of an other constraint can be target-specific and we can't easily + // reason about it. Therefore, be conservative and set MayLoad/MayStore + // for other constriants as well. if (OpInfo.ConstraintType == TargetLowering::C_Memory || OpInfo.ConstraintType == TargetLowering::C_Other) { if (OpInfo.Type == InlineAsm::isInput) |
