diff options
| author | Hans Wennborg <hans@hanshq.net> | 2013-03-18 17:03:05 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2013-03-18 17:03:05 +0000 |
| commit | 7504cefa1431705e1db5d89d448359fe167d8fad (patch) | |
| tree | 137f165aa2a016ab4da7b901e7aca7e091b9b0f0 /llvm/lib/CodeGen | |
| parent | ce26a0aa92cddf7c986a4a164ae07e8d60b6b02d (diff) | |
| download | bcm5719-llvm-7504cefa1431705e1db5d89d448359fe167d8fad.tar.gz bcm5719-llvm-7504cefa1431705e1db5d89d448359fe167d8fad.zip | |
Fix integer comparison in DIEInteger::BestForm.
The always-true "(int)Int == (signed)Int" comparison was found
while experimenting with a potential new Clang warning.
llvm-svn: 177290
Diffstat (limited to 'llvm/lib/CodeGen')
| -rw-r--r-- | llvm/lib/CodeGen/AsmPrinter/DIE.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/llvm/lib/CodeGen/AsmPrinter/DIE.h b/llvm/lib/CodeGen/AsmPrinter/DIE.h index 9907b01ceb6..d087c540f2c 100644 --- a/llvm/lib/CodeGen/AsmPrinter/DIE.h +++ b/llvm/lib/CodeGen/AsmPrinter/DIE.h @@ -235,9 +235,10 @@ namespace llvm { /// static unsigned BestForm(bool IsSigned, uint64_t Int) { if (IsSigned) { - if ((char)Int == (signed)Int) return dwarf::DW_FORM_data1; - if ((short)Int == (signed)Int) return dwarf::DW_FORM_data2; - if ((int)Int == (signed)Int) return dwarf::DW_FORM_data4; + const int64_t SignedInt = Int; + if ((char)Int == SignedInt) return dwarf::DW_FORM_data1; + if ((short)Int == SignedInt) return dwarf::DW_FORM_data2; + if ((int)Int == SignedInt) return dwarf::DW_FORM_data4; } else { if ((unsigned char)Int == Int) return dwarf::DW_FORM_data1; if ((unsigned short)Int == Int) return dwarf::DW_FORM_data2; |
