diff options
author | Kang Zhang <shkzhang@cn.ibm.com> | 2019-08-12 14:00:31 +0000 |
---|---|---|
committer | Kang Zhang <shkzhang@cn.ibm.com> | 2019-08-12 14:00:31 +0000 |
commit | 489efc68a572c42f71590dd6bc0ea21d82d727b3 (patch) | |
tree | 39de40a2e60eecbac8ddac3d6ed943fa770ccb6c /llvm/lib/CodeGen | |
parent | 47298393d2e4d35480d37b0afdea3e899dc798e2 (diff) | |
download | bcm5719-llvm-489efc68a572c42f71590dd6bc0ea21d82d727b3.tar.gz bcm5719-llvm-489efc68a572c42f71590dd6bc0ea21d82d727b3.zip |
Revert r368565: [CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks
llvm-svn: 368574
Diffstat (limited to 'llvm/lib/CodeGen')
-rw-r--r-- | llvm/lib/CodeGen/MachineBlockPlacement.cpp | 37 |
1 files changed, 0 insertions, 37 deletions
diff --git a/llvm/lib/CodeGen/MachineBlockPlacement.cpp b/llvm/lib/CodeGen/MachineBlockPlacement.cpp index 98450f6f164..3000a7d0c3f 100644 --- a/llvm/lib/CodeGen/MachineBlockPlacement.cpp +++ b/llvm/lib/CodeGen/MachineBlockPlacement.cpp @@ -2755,7 +2755,6 @@ void MachineBlockPlacement::optimizeBranches() { // cannot because all branches may not be analyzable. // E.g., the target may be able to remove an unconditional branch to // a fallthrough when it occurs after predicated terminators. - SmallVector<MachineBasicBlock*, 4> EmptyBB; for (MachineBasicBlock *ChainBB : FunctionChain) { Cond.clear(); MachineBasicBlock *TBB = nullptr, *FBB = nullptr; // For AnalyzeBranch. @@ -2775,42 +2774,9 @@ void MachineBlockPlacement::optimizeBranches() { TII->removeBranch(*ChainBB); TII->insertBranch(*ChainBB, FBB, TBB, Cond, dl); ChainBB->updateTerminator(); - } else if (Cond.empty() && TBB && ChainBB != TBB && !TBB->empty() && - !TBB->canFallThrough()) { - // When ChainBB is unconditional branch to the TBB, and TBB has no - // fallthrough predecessor and fallthrough successor, try to merge - // ChainBB and TBB. This is legal under the one of following conditions: - // 1. ChainBB is empty except for an unconditional branch. - // 2. TBB has only one predecessor. - MachineFunction::iterator I(TBB); - if (((TBB == &*F->begin()) || !std::prev(I)->canFallThrough()) && - (TailDup.isSimpleBB(ChainBB) || (TBB->pred_size() == 1))) { - TII->removeBranch(*ChainBB); - ChainBB->removeSuccessor(TBB); - - // Update the CFG. - while (!TBB->pred_empty()) { - MachineBasicBlock *Pred = *(TBB->pred_end()-1); - Pred->ReplaceUsesOfBlockWith(TBB, ChainBB); - } - - for (MachineBasicBlock *Succ : TBB->successors()) - ChainBB->addSuccessor(Succ, MBPI->getEdgeProbability(TBB, Succ)); - - // Move all the instructions of TBB to ChainBB. - ChainBB->splice(ChainBB->end(), TBB, TBB->begin(), TBB->end()); - EmptyBB.push_back(TBB); - } } } } - - for (auto BB: EmptyBB) { - MLI->removeBlock(BB); - FunctionChain.remove(BB); - BlockToChain.erase(BB); - F->erase(BB); - } } void MachineBlockPlacement::alignBlocks() { @@ -3130,9 +3096,6 @@ bool MachineBlockPlacement::runOnMachineFunction(MachineFunction &MF) { } } - // optimizeBranches() may change the blocks, but we haven't updated the - // post-dominator tree. Because the post-dominator tree won't be used after - // this function and this pass don't preserve the post-dominator tree. optimizeBranches(); alignBlocks(); |