diff options
| author | Sam McCall <sam.mccall@gmail.com> | 2018-06-29 14:47:57 +0000 |
|---|---|---|
| committer | Sam McCall <sam.mccall@gmail.com> | 2018-06-29 14:47:57 +0000 |
| commit | 27c979ace0f8ee71e020984ce408628b81c6a7b4 (patch) | |
| tree | 53e2f73a60174fcbe3cb6ce6af01e12911d376a6 /llvm/lib/CodeGen | |
| parent | 0751a0307af385b5a4fb23c3ed305323000fabc3 (diff) | |
| download | bcm5719-llvm-27c979ace0f8ee71e020984ce408628b81c6a7b4.tar.gz bcm5719-llvm-27c979ace0f8ee71e020984ce408628b81c6a7b4.zip | |
[clangd] codeComplete returns more structured completion items, LSP. NFC.
Summary:
LSP has some presentational fields with limited semantics (e.g. 'detail') and
doesn't provide a good place to return information like namespace.
Some places where more detailed information is useful:
- tools like quality analysis
- alternate frontends that aren't strictly LSP
- code completion unit tests
In this patch, ClangdServer::codeComplete still return LSP CompletionList, but
I plan to switch that soon (should be a no-op for ClangdLSPServer).
Deferring this makes it clear that we don't change behavior (tests stay the
same) and also keeps the API break to a small patch which can be reverted.
Reviewers: ioeric
Subscribers: ilya-biryukov, MaskRay, cfe-commits, jkorous
Differential Revision: https://reviews.llvm.org/D48762
llvm-svn: 335980
Diffstat (limited to 'llvm/lib/CodeGen')
0 files changed, 0 insertions, 0 deletions

