diff options
author | Adrian Prantl <aprantl@apple.com> | 2016-12-16 00:36:43 +0000 |
---|---|---|
committer | Adrian Prantl <aprantl@apple.com> | 2016-12-16 00:36:43 +0000 |
commit | ce13935776a67c6bf7fffc3a0db76d27bfbd050a (patch) | |
tree | 35634382729a60f610a4e72f5e511d75971f719a /llvm/lib/CodeGen/TwoAddressInstructionPass.cpp | |
parent | 35bbcefb4be62f6f5a9630d8f0664c97e52b2b20 (diff) | |
download | bcm5719-llvm-ce13935776a67c6bf7fffc3a0db76d27bfbd050a.tar.gz bcm5719-llvm-ce13935776a67c6bf7fffc3a0db76d27bfbd050a.zip |
[IR] Remove the DIExpression field from DIGlobalVariable.
This patch implements PR31013 by introducing a
DIGlobalVariableExpression that holds a pair of DIGlobalVariable and
DIExpression.
Currently, DIGlobalVariables holds a DIExpression. This is not the
best way to model this:
(1) The DIGlobalVariable should describe the source level variable,
not how to get to its location.
(2) It makes it unsafe/hard to update the expressions when we call
replaceExpression on the DIGLobalVariable.
(3) It makes it impossible to represent a global variable that is in
more than one location (e.g., a variable with multiple
DW_OP_LLVM_fragment-s). We also moved away from attaching the
DIExpression to DILocalVariable for the same reasons.
<rdar://problem/29250149>
https://llvm.org/bugs/show_bug.cgi?id=31013
Differential Revision: https://reviews.llvm.org/D26769
llvm-svn: 289902
Diffstat (limited to 'llvm/lib/CodeGen/TwoAddressInstructionPass.cpp')
0 files changed, 0 insertions, 0 deletions