diff options
author | Artem Dergachev <artem.dergachev@gmail.com> | 2018-01-18 01:01:56 +0000 |
---|---|---|
committer | Artem Dergachev <artem.dergachev@gmail.com> | 2018-01-18 01:01:56 +0000 |
commit | db6ca05a6b84c79356c22031b6ec13af76dadad0 (patch) | |
tree | 61502355e87db2851e9141b1d4c54d781bbcfc31 /llvm/lib/CodeGen/TargetPassConfig.cpp | |
parent | b60a80a37be50a0d7c5739a9f43cc4688628d365 (diff) | |
download | bcm5719-llvm-db6ca05a6b84c79356c22031b6ec13af76dadad0.tar.gz bcm5719-llvm-db6ca05a6b84c79356c22031b6ec13af76dadad0.zip |
[analyzer] NFC: RetainCount: Protect from dumping raw region to path notes.
MemRegion::getString() is a wrapper around MemRegion::dump(), which is not
user-friendly and should never be used for diagnostic messages.
Actual cases where raw dumps were reaching the user were unintentionally fixed
in r315736; these were noticed accidentally and shouldn't be reproducible
anymore. For now RetainCountChecker only tracks pointers through variable
regions, and for those dumps are "fine". However, we should still use a less
dangerous method for producing our path notes.
This patch replaces the dump with printing a variable name, asserting that this
is indeed a variable.
Differential Revision: https://reviews.llvm.org/D42015
llvm-svn: 322799
Diffstat (limited to 'llvm/lib/CodeGen/TargetPassConfig.cpp')
0 files changed, 0 insertions, 0 deletions