diff options
| author | Nicolai Haehnle <nhaehnle@gmail.com> | 2018-10-31 13:26:48 +0000 |
|---|---|---|
| committer | Nicolai Haehnle <nhaehnle@gmail.com> | 2018-10-31 13:26:48 +0000 |
| commit | 28212cc6891559855d41066d68e64a84097bb749 (patch) | |
| tree | 58796a00d00b99291d0b62e166d4dce0242cb6a6 /llvm/lib/CodeGen/SplitKit.h | |
| parent | 2efccd2cf2804e2143c67c01bdfa44c5e3d887ac (diff) | |
| download | bcm5719-llvm-28212cc6891559855d41066d68e64a84097bb749.tar.gz bcm5719-llvm-28212cc6891559855d41066d68e64a84097bb749.zip | |
AMDGPU: Remove PHI loop condition optimization
Summary:
The optimization to early break out of loops if all threads are dead was
never fully implemented.
But the PHI node analyzing is actually causing a number of problems, so
remove all the extra code for it.
(This does actually regress code quality in a few places because it
ends up relying more heavily on phi's of i1, which we don't do a
great job with. However, since it fixes real bugs in the wild, we
should take this change. I have some prototype changes to improve
i1 lowering in general -- not just for control flow -- which should
help recover the code quality, I just need to make those changes
fit for general consumption. -- Nicolai)
Change-Id: I6fc6c6c8961857ac6009fcfb9f7e5e48dc23fbb1
Patch-by: Christian König <christian.koenig@amd.com>
Reviewers: arsenm, rampitec, tpr
Subscribers: kzhuravl, jvesely, wdng, yaxunl, dstuttard, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D53359
llvm-svn: 345718
Diffstat (limited to 'llvm/lib/CodeGen/SplitKit.h')
0 files changed, 0 insertions, 0 deletions
