summaryrefslogtreecommitdiffstats
path: root/llvm/lib/CodeGen/SplitKit.cpp
diff options
context:
space:
mode:
authorJakob Stoklund Olesen <stoklund@2pi.dk>2010-08-18 20:06:05 +0000
committerJakob Stoklund Olesen <stoklund@2pi.dk>2010-08-18 20:06:05 +0000
commitf4088b022a690c740a15556d7f347a6049a6015e (patch)
tree39498a000f69fc66170d00c44e4209fc318ae272 /llvm/lib/CodeGen/SplitKit.cpp
parente1be14df1e0dab36d4c9b2b955d799c9d7dbb8b3 (diff)
downloadbcm5719-llvm-f4088b022a690c740a15556d7f347a6049a6015e.tar.gz
bcm5719-llvm-f4088b022a690c740a15556d7f347a6049a6015e.zip
Revert r111394. It was too aggressive.
We must complete the DFS, otherwise we might miss needed phi-defs, and prematurely color live ranges with a non-dominating value. This is not a big deal since we get to color more of the CFG and the next mapValue call will be faster. llvm-svn: 111397
Diffstat (limited to 'llvm/lib/CodeGen/SplitKit.cpp')
-rw-r--r--llvm/lib/CodeGen/SplitKit.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/llvm/lib/CodeGen/SplitKit.cpp b/llvm/lib/CodeGen/SplitKit.cpp
index dae282dfce6..b081bf37337 100644
--- a/llvm/lib/CodeGen/SplitKit.cpp
+++ b/llvm/lib/CodeGen/SplitKit.cpp
@@ -446,9 +446,9 @@ VNInfo *LiveIntervalMap::mapValue(const VNInfo *ParentVNI, SlotIndex Idx) {
}
// No need to search the children, we found a dominating value.
- // MBB is either the found dominating value, or the last phi-def we created.
- // Either way, the children of MBB would be shadowed, so don't search them.
- IDFI.skipChildren(MBB);
+ // FIXME: We could prune up to the last phi-def we inserted, need df_iterator
+ // for that.
+ IDFI.skipChildren();
}
// The search should at least find a dominating value for IdxMBB.
OpenPOWER on IntegriCloud