diff options
author | Eric Christopher <echristo@apple.com> | 2011-06-03 17:21:23 +0000 |
---|---|---|
committer | Eric Christopher <echristo@apple.com> | 2011-06-03 17:21:23 +0000 |
commit | fbff0e4f26bc3e9face0081bc8b005e810fe8989 (patch) | |
tree | a38349d7dc0e5f70d8c739a9cb10df8c20e3ae83 /llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | |
parent | 060b994a293dc082dd78437c6988f32ddccf6c3d (diff) | |
download | bcm5719-llvm-fbff0e4f26bc3e9face0081bc8b005e810fe8989.tar.gz bcm5719-llvm-fbff0e4f26bc3e9face0081bc8b005e810fe8989.zip |
Add a TODO about memory operands.
llvm-svn: 132559
Diffstat (limited to 'llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp')
-rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp index 6da80dbd6a0..3ff4da4a28a 100644 --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp @@ -5735,7 +5735,11 @@ void SelectionDAGBuilder::visitInlineAsm(ImmutableCallSite CS) { // Memory operands really want the address of the value. If we don't have // an indirect input, put it in the constpool if we can, otherwise spill // it to a stack slot. - + // TODO: This isn't quite right. We need to handle these according to + // the addressing mode that the constraint wants. Also, this may take + // an additional register for the computation and we don't want that + // either. + // If the operand is a float, integer, or vector constant, spill to a // constant pool entry to get its address. const Value *OpVal = OpInfo.CallOperandVal; |