diff options
| author | James Molloy <james.molloy@arm.com> | 2012-03-01 14:32:18 +0000 |
|---|---|---|
| committer | James Molloy <james.molloy@arm.com> | 2012-03-01 14:32:18 +0000 |
| commit | f6298e928177a6282a159c6cadd45582513e9cef (patch) | |
| tree | b05b4ce0492942bf9e523f1fff75c5809cdc1627 /llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | |
| parent | e39d7ac3963d8d95f9fad0edec6c22e64dcdbd0b (diff) | |
| download | bcm5719-llvm-f6298e928177a6282a159c6cadd45582513e9cef.tar.gz bcm5719-llvm-f6298e928177a6282a159c6cadd45582513e9cef.zip | |
Fix a codegen fault in which log2 or exp2 could be dead-code eliminated even though they could have sideeffects.
Only allow log2/exp2 to be converted to an intrinsic if they are declared "readnone".
llvm-svn: 151807
Diffstat (limited to 'llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp index 0038633cd6e..4a6f409a16c 100644 --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp @@ -5627,7 +5627,8 @@ void SelectionDAGBuilder::visitCall(const CallInst &I) { (LibInfo->has(LibFunc::log2l) && Name == "log2l")) { if (I.getNumArgOperands() == 1 && // Basic sanity checks. I.getArgOperand(0)->getType()->isFloatingPointTy() && - I.getType() == I.getArgOperand(0)->getType()) { + I.getType() == I.getArgOperand(0)->getType() && + I.onlyReadsMemory()) { SDValue Tmp = getValue(I.getArgOperand(0)); setValue(&I, DAG.getNode(ISD::FLOG2, getCurDebugLoc(), Tmp.getValueType(), Tmp)); @@ -5638,7 +5639,8 @@ void SelectionDAGBuilder::visitCall(const CallInst &I) { (LibInfo->has(LibFunc::exp2l) && Name == "exp2l")) { if (I.getNumArgOperands() == 1 && // Basic sanity checks. I.getArgOperand(0)->getType()->isFloatingPointTy() && - I.getType() == I.getArgOperand(0)->getType()) { + I.getType() == I.getArgOperand(0)->getType() && + I.onlyReadsMemory()) { SDValue Tmp = getValue(I.getArgOperand(0)); setValue(&I, DAG.getNode(ISD::FEXP2, getCurDebugLoc(), Tmp.getValueType(), Tmp)); |
