diff options
| author | Pirama Arumuga Nainar <pirama@google.com> | 2018-11-08 20:10:07 +0000 |
|---|---|---|
| committer | Pirama Arumuga Nainar <pirama@google.com> | 2018-11-08 20:10:07 +0000 |
| commit | e61652a38427b65206856f3ddc1cd55b42ad7dfd (patch) | |
| tree | f029a7ae2b972732e7ba514f99255f8a9de70f0b /llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp | |
| parent | d17315d89885236c1409bec0311a55f62a8ceda1 (diff) | |
| download | bcm5719-llvm-e61652a38427b65206856f3ddc1cd55b42ad7dfd.tar.gz bcm5719-llvm-e61652a38427b65206856f3ddc1cd55b42ad7dfd.zip | |
[LTO] Drop non-prevailing definitions only if linkage is not local or appending
Summary:
This fixes PR 37422
In ELF, non-weak symbols can also be non-prevailing. In this particular
PR, the __llvm_profile_* symbols are non-prevailing but weren't getting
dropped - causing multiply-defined errors with lld.
Also add a test, strong_non_prevailing.ll, to ensure that multiple
copies of a strong symbol are dropped.
To fix the test regressions exposed by this fix,
- do not mark prevailing copies for symbols with 'appending' linkage.
There's no one prevailing copy for such symbols.
- fix the prevailing version in dead-strip-fulllto.ll
- explicitly pass exported symbols to llvm-lto in fumcimport.ll and
funcimport_var.ll
Reviewers: tejohnson, pcc
Subscribers: mehdi_amini, inglorion, eraman, steven_wu, dexonsmith,
dang, srhines, llvm-commits
Differential Revision: https://reviews.llvm.org/D54125
llvm-svn: 346436
Diffstat (limited to 'llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp')
0 files changed, 0 insertions, 0 deletions
