diff options
author | Evan Cheng <evan.cheng@apple.com> | 2012-12-12 20:43:23 +0000 |
---|---|---|
committer | Evan Cheng <evan.cheng@apple.com> | 2012-12-12 20:43:23 +0000 |
commit | b7d3d03bf91e4ae1eb0677ff62d48f80d4414311 (patch) | |
tree | 3e3d63a71bb66d2a09201044d42219e8290f5328 /llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp | |
parent | 0a74fc8d6ca83ddc3b3b5ac7792fe7b9b62e6c04 (diff) | |
download | bcm5719-llvm-b7d3d03bf91e4ae1eb0677ff62d48f80d4414311.tar.gz bcm5719-llvm-b7d3d03bf91e4ae1eb0677ff62d48f80d4414311.zip |
Fix a logic bug in inline expansion of memcpy / memset with an overlapping
load / store pair. It's not legal to use a wider load than the size of
the remaining bytes if it's the first pair of load / store.
llvm-svn: 170018
Diffstat (limited to 'llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp')
-rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp index 269f22150a9..23751821673 100644 --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp @@ -3469,9 +3469,6 @@ static bool FindOptimalMemOpLowering(std::vector<EVT> &MemOps, unsigned NumMemOps = 0; while (Size != 0) { - if (++NumMemOps > Limit) - return false; - unsigned VTSize = VT.getSizeInBits() / 8; while (VTSize > Size) { // For now, only use non-vector load / store's for the left-over pieces. @@ -3507,7 +3504,8 @@ static bool FindOptimalMemOpLowering(std::vector<EVT> &MemOps, // FIXME: Only does this for 64-bit or more since we don't have proper // cost model for unaligned load / store. bool Fast; - if (AllowOverlap && VTSize >= 8 && NewVTSize < Size && + if (NumMemOps && AllowOverlap && + VTSize >= 8 && NewVTSize < Size && TLI.allowsUnalignedMemoryAccesses(VT, &Fast) && Fast) VTSize = Size; else { @@ -3516,6 +3514,9 @@ static bool FindOptimalMemOpLowering(std::vector<EVT> &MemOps, } } + if (++NumMemOps > Limit) + return false; + MemOps.push_back(VT); Size -= VTSize; } |