diff options
author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2018-03-13 17:17:15 +0000 |
---|---|---|
committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2018-03-13 17:17:15 +0000 |
commit | 9855b3938093eb4a3663474a42a1a694327816c0 (patch) | |
tree | 3045d2a84bc5a492b0afa9277b958b8c0708173d /llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | |
parent | 8afcd938ed9cc51dd7db79171d1b06d1e479b3dc (diff) | |
download | bcm5719-llvm-9855b3938093eb4a3663474a42a1a694327816c0.tar.gz bcm5719-llvm-9855b3938093eb4a3663474a42a1a694327816c0.zip |
[DAGCombine] visitREM - Don't assume that one divrem isn't driving another
Under some circumstances the divrems won't have been combined together before getting to this code.
So replace the assertion with a if() guard to not expand to X-((X/C)*C) to give the other combine chance to happen.
Reduced from OSS-Fuzz #6883
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6883
llvm-svn: 327424
Diffstat (limited to 'llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp')
-rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index d0e2f918278..48cfe4f57a1 100644 --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -3068,9 +3068,9 @@ SDValue DAGCombiner::visitREM(SDNode *N) { SDValue Div = DAG.getNode(DivOpcode, DL, VT, N0, N1); AddToWorklist(Div.getNode()); SDValue OptimizedDiv = combine(Div.getNode()); - if (OptimizedDiv.getNode() && OptimizedDiv.getNode() != Div.getNode()) { - assert((OptimizedDiv.getOpcode() != ISD::UDIVREM) && - (OptimizedDiv.getOpcode() != ISD::SDIVREM)); + if (OptimizedDiv.getNode() && OptimizedDiv.getNode() != Div.getNode() && + OptimizedDiv.getOpcode() != ISD::UDIVREM && + OptimizedDiv.getOpcode() != ISD::SDIVREM) { SDValue Mul = DAG.getNode(ISD::MUL, DL, VT, OptimizedDiv, N1); SDValue Sub = DAG.getNode(ISD::SUB, DL, VT, N0, Mul); AddToWorklist(Mul.getNode()); |