diff options
| author | Eli Friedman <efriedma@codeaurora.org> | 2017-10-12 20:54:08 +0000 |
|---|---|---|
| committer | Eli Friedman <efriedma@codeaurora.org> | 2017-10-12 20:54:08 +0000 |
| commit | 48e7549691d7dbe3be1a78f7419953fb48181678 (patch) | |
| tree | ebd74766f7dcff1d508afefb13d25d788ef87e09 /llvm/lib/CodeGen/SafeStackColoring.h | |
| parent | 993d2e67d85a9c137edeeb295ce56d81563b14a7 (diff) | |
| download | bcm5719-llvm-48e7549691d7dbe3be1a78f7419953fb48181678.tar.gz bcm5719-llvm-48e7549691d7dbe3be1a78f7419953fb48181678.zip | |
[DWARF] Fix bad comparator in sortGlobalExprs.
The comparator passed to std::sort must provide a strict weak ordering;
otherwise, the behavior is undefined.
Fixes an assertion failure generating debug info for globals
split by GlobalOpt. I have a testcase, but not sure how to reduce it,
so not included here. (Someone else came up with a testcase, but I
can't reproduce the crash with it, presumably because my version of LLVM
ends up sorting the array differently.)
This isn't really a complete fix (see the FIXME in the patch), but at
least it doesn't have undefined behavior.
Differential Revision: https://reviews.llvm.org/D38830
llvm-svn: 315619
Diffstat (limited to 'llvm/lib/CodeGen/SafeStackColoring.h')
0 files changed, 0 insertions, 0 deletions

