summaryrefslogtreecommitdiffstats
path: root/llvm/lib/CodeGen/PseudoSourceValue.cpp
diff options
context:
space:
mode:
authorDavid Majnemer <david.majnemer@gmail.com>2014-03-09 06:41:58 +0000
committerDavid Majnemer <david.majnemer@gmail.com>2014-03-09 06:41:58 +0000
commitc4ab61cb2fc982fc34d01b7dc71c0a80b81993e3 (patch)
tree55626899f3b6f6232c9d5c058ac161aca36520ac /llvm/lib/CodeGen/PseudoSourceValue.cpp
parent259a5a649f195caf58287473c47a49029e601031 (diff)
downloadbcm5719-llvm-c4ab61cb2fc982fc34d01b7dc71c0a80b81993e3.tar.gz
bcm5719-llvm-c4ab61cb2fc982fc34d01b7dc71c0a80b81993e3.zip
IR: Change inalloca's grammar a bit
The grammar for LLVM IR is not well specified in any document but seems to obey the following rules: - Attributes which have parenthesized arguments are never preceded by commas. This form of attribute is the only one which ever has optional arguments. However, not all of these attributes support optional arguments: 'thread_local' supports an optional argument but 'addrspace' does not. Interestingly, 'addrspace' is documented as being a "qualifier". What constitutes a qualifier? I cannot find a definition. - Some attributes use a space between the keyword and the value. Examples of this form are 'align' and 'section'. These are always preceded by a comma. - Otherwise, the attribute has no argument. These attributes do not have a preceding comma. Sometimes an attribute goes before the instruction, between the instruction and it's type, or after it's type. 'atomicrmw' has 'volatile' between the instruction and the type while 'call' has 'tail' preceding the instruction. With all this in mind, it seems most consistent for 'inalloca' on an 'inalloca' instruction to occur before between the instruction and the type. Unlike the current formulation, there would be no preceding comma. The combination 'alloca inalloca' doesn't look particularly appetizing, perhaps a better spelling of 'inalloca' is down the road. llvm-svn: 203376
Diffstat (limited to 'llvm/lib/CodeGen/PseudoSourceValue.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud