summaryrefslogtreecommitdiffstats
path: root/llvm/lib/CodeGen/ProcessImplicitDefs.cpp
diff options
context:
space:
mode:
authorWei Mi <wmi@google.com>2018-05-01 14:47:24 +0000
committerWei Mi <wmi@google.com>2018-05-01 14:47:24 +0000
commiteec5ba9faea38b911cdd8aaf48cde1bd2e194be4 (patch)
treef198ba8fbc56f21bcb1ac84eb14fd86ea2ae2612 /llvm/lib/CodeGen/ProcessImplicitDefs.cpp
parent54596e1c1a1b1579ab54f4e55cf51a61d10be27d (diff)
downloadbcm5719-llvm-eec5ba9faea38b911cdd8aaf48cde1bd2e194be4.tar.gz
bcm5719-llvm-eec5ba9faea38b911cdd8aaf48cde1bd2e194be4.zip
Fix the issue that ComputeValueKnownInPredecessors only handles the case when
phi is on lhs of a comparison op. For the following testcase, L1: %t0 = add i32 %m, 7 %t3 = icmp eq i32* %t2, null br i1 %t3, label %L3, label %L2 L2: %t4 = load i32, i32* %t2, align 4 br label %L3 L3: %t5 = phi i32 [ %t0, %L1 ], [ %t4, %L2 ] %t6 = icmp eq i32 %t0, %t5 br i1 %t6, label %L4, label %L5 We know if we go through the path L1 --> L3, %t6 should always be true. However currently, if the rhs of the eq comparison is phi, JumpThreading fails to evaluate %t6 to true. And we know that Instcombine cannot guarantee always canonicalizing phi to the left hand side of the comparison operation according to the operand priority comparison mechanism in instcombine. The patch handles the case when rhs of the comparison op is a phi. Differential Revision: https://reviews.llvm.org/D46275 llvm-svn: 331266
Diffstat (limited to 'llvm/lib/CodeGen/ProcessImplicitDefs.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud