diff options
| author | Pedro Artigas <partigas@apple.com> | 2013-11-08 22:46:28 +0000 |
|---|---|---|
| committer | Pedro Artigas <partigas@apple.com> | 2013-11-08 22:46:28 +0000 |
| commit | 71f87cb33a2f4bab49e8c5150a9ccc0d7844c306 (patch) | |
| tree | c8144b2cd45c9183ba727d4a60fa81d36f2fa9a0 /llvm/lib/CodeGen/MachineVerifier.cpp | |
| parent | 2fca51d3b45efcf00ffcfe2879cd6d7d98c26258 (diff) | |
| download | bcm5719-llvm-71f87cb33a2f4bab49e8c5150a9ccc0d7844c306.tar.gz bcm5719-llvm-71f87cb33a2f4bab49e8c5150a9ccc0d7844c306.zip | |
increase the accuracy of register pressure computation in the presence of dead definitions by using live intervals, if available, to identify dead definitions and proceed accordingly.
llvm-svn: 194286
Diffstat (limited to 'llvm/lib/CodeGen/MachineVerifier.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/MachineVerifier.cpp | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/llvm/lib/CodeGen/MachineVerifier.cpp b/llvm/lib/CodeGen/MachineVerifier.cpp index df4568359a2..c57ce9c65c8 100644 --- a/llvm/lib/CodeGen/MachineVerifier.cpp +++ b/llvm/lib/CodeGen/MachineVerifier.cpp @@ -1096,6 +1096,14 @@ void MachineVerifier::checkLiveness(const MachineOperand *MO, unsigned MONum) { report("No live segment at def", MO, MONum); *OS << DefIdx << " is not live in " << LI << '\n'; } + // Check that, if the dead def flag is present, LiveInts agree. + if (MO->isDead()) { + LiveQueryResult LRQ = LI.Query(DefIdx); + if (!LRQ.isDeadDef()) { + report("Live range continues after dead def flag", MO, MONum); + *OS << "Live range: " << LI << '\n'; + } + } } else { report("Virtual register has no Live interval", MO, MONum); } @@ -1517,22 +1525,13 @@ void MachineVerifier::verifyLiveRangeSegment(const LiveRange &LR, // A live segment can end with either a redefinition, a kill flag on a // use, or a dead flag on a def. bool hasRead = false; - bool hasDeadDef = false; for (ConstMIBundleOperands MOI(MI); MOI.isValid(); ++MOI) { if (!MOI->isReg() || MOI->getReg() != Reg) continue; if (MOI->readsReg()) hasRead = true; - if (MOI->isDef() && MOI->isDead()) - hasDeadDef = true; } - - if (S.end.isDead()) { - if (!hasDeadDef) { - report("Instruction doesn't have a dead def operand", MI); - *OS << S << " in " << LR << '\n'; - } - } else { + if (!S.end.isDead()) { if (!hasRead) { report("Instruction ending live segment doesn't read the register", MI); *OS << S << " in " << LR << '\n'; |

