diff options
| author | Evan Cheng <evan.cheng@apple.com> | 2010-04-07 06:00:33 +0000 |
|---|---|---|
| committer | Evan Cheng <evan.cheng@apple.com> | 2010-04-07 06:00:33 +0000 |
| commit | 5ed679282b2ee0ccc536cf68926324566a8897db (patch) | |
| tree | e99133d66d468725a5f6d6e74c1d90cc90130b47 /llvm/lib/CodeGen/MachineLICM.cpp | |
| parent | fcbcc0bd51e27484e110e1fef9e7a44d556456cf (diff) | |
| download | bcm5719-llvm-5ed679282b2ee0ccc536cf68926324566a8897db.tar.gz bcm5719-llvm-5ed679282b2ee0ccc536cf68926324566a8897db.zip | |
Add comments for missed opportunities.
llvm-svn: 100610
Diffstat (limited to 'llvm/lib/CodeGen/MachineLICM.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/MachineLICM.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/llvm/lib/CodeGen/MachineLICM.cpp b/llvm/lib/CodeGen/MachineLICM.cpp index 72f7d4549c8..0edd44ba2e5 100644 --- a/llvm/lib/CodeGen/MachineLICM.cpp +++ b/llvm/lib/CodeGen/MachineLICM.cpp @@ -247,6 +247,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) { if (!CurLoop->contains(BB)) continue; // Conservatively treat live-in's as an external def. + // FIXME: That means a reload that's reused into a fallthrough block + // will not be LICM'ed. for (MachineBasicBlock::const_livein_iterator I = BB->livein_begin(), E = BB->livein_end(); I != E; ++I) { unsigned Reg = *I; @@ -282,7 +284,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) { } } - // FIXME: Only consider reloads for now. + // FIXME: Only consider reloads for now. We should be able to handle + // remat which does not have register operands. bool SkipCheck = false; int FI; if (SeenDef && !RuledOut) { |
