diff options
author | Sam McCall <sam.mccall@gmail.com> | 2018-01-31 13:40:48 +0000 |
---|---|---|
committer | Sam McCall <sam.mccall@gmail.com> | 2018-01-31 13:40:48 +0000 |
commit | d1a7a37c22c9a716818f76c7edd1a657bda0f441 (patch) | |
tree | f80919eeecda16bc6890e8ff6b6f3cfc94d4090c /llvm/lib/CodeGen/MachineCombiner.cpp | |
parent | dd48c6b5194c1fc16be73b5e8e4db554c60af33b (diff) | |
download | bcm5719-llvm-d1a7a37c22c9a716818f76c7edd1a657bda0f441.tar.gz bcm5719-llvm-d1a7a37c22c9a716818f76c7edd1a657bda0f441.zip |
[clangd] Pass Context implicitly using TLS.
Summary:
Instead of passing Context explicitly around, we now have a thread-local
Context object `Context::current()` which is an implicit argument to
every function.
Most manipulation of this should use the WithContextValue helper, which
augments the current Context to add a single KV pair, and restores the
old context on destruction.
Advantages are:
- less boilerplate in functions that just propagate contexts
- reading most code doesn't require understanding context at all, and
using context as values in fewer places still
- fewer options to pass the "wrong" context when it changes within a
scope (e.g. when using Span)
- contexts pass through interfaces we can't modify, such as VFS
- propagating contexts across threads was slightly tricky (e.g.
copy vs move, no move-init in lambdas), and is now encapsulated in
the threadpool
Disadvantages are all the usual TLS stuff - hidden magic, and
potential for higher memory usage on threads that don't use the
context. (In practice, it's just one pointer)
Reviewers: ilya-biryukov
Subscribers: klimek, jkorous-apple, ioeric, cfe-commits
Differential Revision: https://reviews.llvm.org/D42517
llvm-svn: 323872
Diffstat (limited to 'llvm/lib/CodeGen/MachineCombiner.cpp')
0 files changed, 0 insertions, 0 deletions