summaryrefslogtreecommitdiffstats
path: root/llvm/lib/CodeGen/MachineCombiner.cpp
diff options
context:
space:
mode:
authorKevin Enderby <enderby@apple.com>2015-10-06 22:27:08 +0000
committerKevin Enderby <enderby@apple.com>2015-10-06 22:27:08 +0000
commita59824a174f69fc07f715efc220e26f8c2620e3c (patch)
treeaf074e3aee6b6e3f478cd9766317ccc1ffeb440a /llvm/lib/CodeGen/MachineCombiner.cpp
parent702c4b865e0f4767c3c39b022b8b37dafe5197ef (diff)
downloadbcm5719-llvm-a59824a174f69fc07f715efc220e26f8c2620e3c.tar.gz
bcm5719-llvm-a59824a174f69fc07f715efc220e26f8c2620e3c.zip
Fix two bugs in llvm-objdump’s printing of Objective-C meta data
from malformed Mach-O files that caused crashes. We recently got about 700 malformed Mach-O files which we have been using the improve the robustness of tools that deal with reading data from object files. These resulted in about 20 small bug fixes to the darwin based tools. The goal here is to also improve the robustness of llvm-objdump and this is the first two fixes. In talking with Tim Northover the approach we thought might be best is to: 1) Only include tests for the malformed Mach-O files that cause crashes (not all 700+ tests). 2) The test should only contain the command line option that caused the crash and not all the others that don’t matter. 3) There should be only one line for the FileCheck that is past the point of the crash if possible and if possible indicates the malformation. Again the goal is to fix crashes and not so much care about how the printing of malformed data comes out. Tim also suggested if we really wanted to add test cases for all 700+ malformed Mach-O files putting them in the regression tests might be an option. But many of these do not cause crashes. llvm-svn: 249479
Diffstat (limited to 'llvm/lib/CodeGen/MachineCombiner.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud