diff options
author | Hans Wennborg <hans@hanshq.net> | 2019-08-22 13:15:36 +0000 |
---|---|---|
committer | Hans Wennborg <hans@hanshq.net> | 2019-08-22 13:15:36 +0000 |
commit | 8288453f6aac05080b751b680455349e09d49825 (patch) | |
tree | 255701fd79a51c22178f15ac068526edbd860bb8 /llvm/lib/CodeGen/MachineBasicBlock.cpp | |
parent | 5215770e88ee71321466a4904a4ab628af687673 (diff) | |
download | bcm5719-llvm-8288453f6aac05080b751b680455349e09d49825.tar.gz bcm5719-llvm-8288453f6aac05080b751b680455349e09d49825.zip |
Revert r369402 "win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer"
This broke compiling some ASan tests with never versions of MSVC/the Win
SDK, see https://crbug.com/996675
> MSVC 2017 update 3 (_MSC_VER 1911) enables /Zc:twoPhase by default, and
> so should clang-cl:
> https://docs.microsoft.com/en-us/cpp/build/reference/zc-twophase
>
> clang-cl takes the MSVC version it emulates from the -fmsc-version flag,
> or if that's not passed it tries to check what the installed version of
> MSVC is and uses that, and failing that it uses a default version that's
> currently 1911. So this changes the default if no -fmsc-version flag is
> passed and no installed MSVC is detected. (It also changes the default
> if -fmsc-version is passed or MSVC is detected, and either indicates
> _MSC_VER >= 1911.)
>
> As mentioned in the MSDN article, the Windows SDK header files in
> version 10.0.15063.0 (Creators Update or Redstone 2) and earlier
> versions do not work correctly with /Zc:twoPhase. If you need to use
> these old SDKs with a new clang-cl, explicitly pass /Zc:twoPhase- to get
> the old behavior.
>
> Fixes PR43032.
>
> Differential Revision: https://reviews.llvm.org/D66394
llvm-svn: 369647
Diffstat (limited to 'llvm/lib/CodeGen/MachineBasicBlock.cpp')
0 files changed, 0 insertions, 0 deletions