diff options
| author | Bill Wendling <isanbard@gmail.com> | 2008-06-23 23:41:14 +0000 |
|---|---|---|
| committer | Bill Wendling <isanbard@gmail.com> | 2008-06-23 23:41:14 +0000 |
| commit | c44659b92a956e7a8264dc463d923eb537c2d1aa (patch) | |
| tree | fce4ee3f9fffcad2b9f69c2bd8be36fde0f7910e /llvm/lib/CodeGen/LiveVariables.cpp | |
| parent | 0d8a61eb60091b607fe4673a4c09276bf418676c (diff) | |
| download | bcm5719-llvm-c44659b92a956e7a8264dc463d923eb537c2d1aa.tar.gz bcm5719-llvm-c44659b92a956e7a8264dc463d923eb537c2d1aa.zip | |
This situation can occur:
,------.
| |
| v
| t2 = phi ... t1 ...
| |
| v
| t1 = ...
| ... = ... t1 ...
| |
`------'
where there is a use in a PHI node that's a predecessor to the defining
block. We don't want to mark all predecessors as having the value "alive" in
this case. Also, the assert was too restrictive and didn't handle this case.
llvm-svn: 52655
Diffstat (limited to 'llvm/lib/CodeGen/LiveVariables.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/LiveVariables.cpp | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/LiveVariables.cpp b/llvm/lib/CodeGen/LiveVariables.cpp index 4a4ef37b004..bc73b6841c4 100644 --- a/llvm/lib/CodeGen/LiveVariables.cpp +++ b/llvm/lib/CodeGen/LiveVariables.cpp @@ -139,8 +139,23 @@ void LiveVariables::HandleVirtRegUse(unsigned reg, MachineBasicBlock *MBB, assert(VRInfo.Kills[i]->getParent() != MBB && "entry should be at end!"); #endif - assert(MBB != MRI->getVRegDef(reg)->getParent() && - "Should have kill for defblock!"); + // This situation can occur: + // + // ,------. + // | | + // | v + // | t2 = phi ... t1 ... + // | | + // | v + // | t1 = ... + // | ... = ... t1 ... + // | | + // `------' + // + // where there is a use in a PHI node that's a predecessor to the defining + // block. We don't want to mark all predecessors as having the value "alive" + // in this case. + if (MBB == MRI->getVRegDef(reg)->getParent()) return; // Add a new kill entry for this basic block. If this virtual register is // already marked as alive in this basic block, that means it is alive in at |
