summaryrefslogtreecommitdiffstats
path: root/llvm/lib/CodeGen/GlobalMerge.cpp
diff options
context:
space:
mode:
authorDavid Green <david.green@arm.com>2018-06-06 14:48:32 +0000
committerDavid Green <david.green@arm.com>2018-06-06 14:48:32 +0000
commit25312b2b6c945e1cd236dc679b174114d96d840e (patch)
treededf999be925a52b616746b4f929a61e25c9e247 /llvm/lib/CodeGen/GlobalMerge.cpp
parent566c74cc9850f421f54f4790d996517cb8a52b03 (diff)
downloadbcm5719-llvm-25312b2b6c945e1cd236dc679b174114d96d840e.tar.gz
bcm5719-llvm-25312b2b6c945e1cd236dc679b174114d96d840e.zip
[GlobalMerge] Set the alignment on merged global structs
If no alignment is set, the abi/preferred alignment of structs will be used which may be higher than required. This can lead to extra padding and in the end an increase in data size. Differential Revision: https://reviews.llvm.org/D47633 llvm-svn: 334099
Diffstat (limited to 'llvm/lib/CodeGen/GlobalMerge.cpp')
-rw-r--r--llvm/lib/CodeGen/GlobalMerge.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/llvm/lib/CodeGen/GlobalMerge.cpp b/llvm/lib/CodeGen/GlobalMerge.cpp
index fbf94d2bb7f..bebf1d6d4cd 100644
--- a/llvm/lib/CodeGen/GlobalMerge.cpp
+++ b/llvm/lib/CodeGen/GlobalMerge.cpp
@@ -500,6 +500,11 @@ bool GlobalMerge::doMerge(const SmallVectorImpl<GlobalVariable *> &Globals,
GlobalVariable::NotThreadLocal, AddrSpace);
const StructLayout *MergedLayout = DL.getStructLayout(MergedTy);
+ // Set the alignment of the merged struct as the maximum alignment of the
+ // globals to prevent over-alignment. We don't handle globals that are not
+ // default aligned, so the alignment of the MergedLayout struct is
+ // equivalent.
+ MergedGV->setAlignment(MergedLayout->getAlignment());
for (ssize_t k = i, idx = 0; k != j; k = GlobalSet.find_next(k), ++idx) {
GlobalValue::LinkageTypes Linkage = Globals[k]->getLinkage();
OpenPOWER on IntegriCloud