diff options
author | Pavel Labath <labath@google.com> | 2017-02-22 10:38:02 +0000 |
---|---|---|
committer | Pavel Labath <labath@google.com> | 2017-02-22 10:38:02 +0000 |
commit | a385d2c1b66726ae7ca8960cb84fe3c146110019 (patch) | |
tree | 60c5dc3989a90bb69d5e47696a411d08105825ce /llvm/lib/CodeGen/GlobalISel/InstructionSelector.cpp | |
parent | 048b3ece1db993cd0033d567a9396d372895f37a (diff) | |
download | bcm5719-llvm-a385d2c1b66726ae7ca8960cb84fe3c146110019.tar.gz bcm5719-llvm-a385d2c1b66726ae7ca8960cb84fe3c146110019.zip |
Replace WINLOG_*** macros with LLDB_LOG
Summary:
The main difference here is that in the WINLOG macros you can specify
log categories per call, whereas here you have to go the usual lldb
route of getting a Log* variable first. While this means you have to
write at least two statements, it usually means that each statement will
fit on a single line, whereas fitting the WINLOG invocation on a single
line was almost impossible. So the total size of code does not increase
even in functions with a single log statement, and functions with more
logging get shorter.
The downside here is reduced flexibility in specifying the log
categories, which a couple of functions used quite heavily (e.g.
RefreshStateAfterStop). For these I chose a single category used most
prominently and put everything into that, although a solution with
multiple log variables is definitely possible.
Reviewers: zturner, amccarth
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D30172
llvm-svn: 295822
Diffstat (limited to 'llvm/lib/CodeGen/GlobalISel/InstructionSelector.cpp')
0 files changed, 0 insertions, 0 deletions