diff options
| author | Frederic Riss <friss@apple.com> | 2014-11-11 21:21:08 +0000 |
|---|---|---|
| committer | Frederic Riss <friss@apple.com> | 2014-11-11 21:21:08 +0000 |
| commit | 8ad4f498fb4d273a35a0a3cd41492fa7467c5384 (patch) | |
| tree | 4464dfb4e065c03a7cc5b2e65cb3769986659a14 /llvm/lib/CodeGen/ForwardControlFlowIntegrity.cpp | |
| parent | eb7a303d1beb57484d8e559801552fd9745a0d78 (diff) | |
| download | bcm5719-llvm-8ad4f498fb4d273a35a0a3cd41492fa7467c5384.tar.gz bcm5719-llvm-8ad4f498fb4d273a35a0a3cd41492fa7467c5384.zip | |
Totally forget deallocated SDNodes in SDDbgInfo.
What would happen before that commit is that the SDDbgValues associated with
a deallocated SDNode would be marked Invalidated, but SDDbgInfo would keep
a map entry keyed by the SDNode pointer pointing to this list of invalidated
SDDbgNodes. As the memory gets reused, the list might get wrongly associated
with another new SDNode. As the SDDbgValues are cloned when they are transfered,
this can lead to an exponential number of SDDbgValues being produced during
DAGCombine like in http://llvm.org/bugs/show_bug.cgi?id=20893
Note that the previous behavior wasn't really buggy as the invalidation made
sure that the SDDbgValues won't be used. This commit can be considered a
memory optimization and as such is really hard to validate in a unit-test.
llvm-svn: 221709
Diffstat (limited to 'llvm/lib/CodeGen/ForwardControlFlowIntegrity.cpp')
0 files changed, 0 insertions, 0 deletions
