diff options
author | Bill Wendling <isanbard@gmail.com> | 2011-06-01 01:49:35 +0000 |
---|---|---|
committer | Bill Wendling <isanbard@gmail.com> | 2011-06-01 01:49:35 +0000 |
commit | 48581a64547a14475cf3ba7c9ccc1f073d081e6e (patch) | |
tree | 6f03d7742adc17ae657be7485773ead3d1642480 /llvm/lib/CodeGen/DwarfEHPrepare.cpp | |
parent | 9978c4f7307bc2c0360fc0badf88c3ed9122f391 (diff) | |
download | bcm5719-llvm-48581a64547a14475cf3ba7c9ccc1f073d081e6e.tar.gz bcm5719-llvm-48581a64547a14475cf3ba7c9ccc1f073d081e6e.zip |
The ARM stuff already calls the Resume function, not the Resume_or_Rethrow. It
turns out that it could cause an infinite loop in some situations. If this code
is triggered and it converts a cleanup into a catchall, but that cleanup was in
already in a cleanup, then the _Unwind_SjLj_Resume could infinite loop. I.e.,
the code doesn't consume the exception object and passes it on to
_Unwind_SjLj_Resume. But _USjLjR expects it to be consumed (since it's landing
at a catchall instead of a cleanup). So it uses the values that are presently
there, which are the values that tell it to jump to the fake landing pad.
<rdar://problem/9508402>
llvm-svn: 132381
Diffstat (limited to 'llvm/lib/CodeGen/DwarfEHPrepare.cpp')
-rw-r--r-- | llvm/lib/CodeGen/DwarfEHPrepare.cpp | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/llvm/lib/CodeGen/DwarfEHPrepare.cpp b/llvm/lib/CodeGen/DwarfEHPrepare.cpp index 873ddd20b8c..22c5465bf9f 100644 --- a/llvm/lib/CodeGen/DwarfEHPrepare.cpp +++ b/llvm/lib/CodeGen/DwarfEHPrepare.cpp @@ -252,10 +252,7 @@ bool DwarfEHPrepare::HandleURoRInvokes() { if (!URoR) { URoR = F->getParent()->getFunction("_Unwind_Resume_or_Rethrow"); - if (!URoR) { - URoR = F->getParent()->getFunction("_Unwind_SjLj_Resume"); - if (!URoR) return CleanupSelectors(CatchAllSels); - } + if (!URoR) return CleanupSelectors(CatchAllSels); } SmallPtrSet<InvokeInst*, 32> URoRInvokes; |