diff options
author | Haojian Wu <hokein@google.com> | 2017-12-19 20:52:56 +0000 |
---|---|---|
committer | Haojian Wu <hokein@google.com> | 2017-12-19 20:52:56 +0000 |
commit | 7934685c3d19229e7784594a2434649fc67cdf3d (patch) | |
tree | e0aac6e2a549f16d1e82b747c5d69a5ed4089435 /llvm/lib/CodeGen/CodeGenPrepare.cpp | |
parent | 5e8cba9e394b8cdf84486d5a85a53c8eb7d1f932 (diff) | |
download | bcm5719-llvm-7934685c3d19229e7784594a2434649fc67cdf3d.tar.gz bcm5719-llvm-7934685c3d19229e7784594a2434649fc67cdf3d.zip |
[clangd] Don't use the optional "severity" when comparing Diagnostic.
Summary:
We use Diagnostic as a key to find the corresponding FixIt when we do
the "apply-fix", but the "severity" field could be omitted, in some cases,
the codeAction request sent from LSP clients (e.g. VScode) doesn't include the
`severity` field, which makes clangd fail to find the FixIt.
Test the following code in VScode, before the fix, no FixIt shown.
```
void main() {}
^~~~
```
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: klimek, ilya-biryukov, cfe-commits
Differential Revision: https://reviews.llvm.org/D41280
llvm-svn: 321106
Diffstat (limited to 'llvm/lib/CodeGen/CodeGenPrepare.cpp')
0 files changed, 0 insertions, 0 deletions