diff options
author | Reid Kleckner <rnk@google.com> | 2016-01-14 00:12:54 +0000 |
---|---|---|
committer | Reid Kleckner <rnk@google.com> | 2016-01-14 00:12:54 +0000 |
commit | 3c0ff987087237af282764bef794ccf7e1dca4d0 (patch) | |
tree | 6a934310fb4a7241533993497f977b51a13577a9 /llvm/lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp | |
parent | 38b3130c7aa8e4f40949cd3001a75b4d2fcda540 (diff) | |
download | bcm5719-llvm-3c0ff987087237af282764bef794ccf7e1dca4d0.tar.gz bcm5719-llvm-3c0ff987087237af282764bef794ccf7e1dca4d0.zip |
[codeview] Regenerate C++ display name test case and update comments
Clang generates good display names for codeview since r255744, and the
change to make LLVM use them was accidentally included in r257658.
This change just updates the comments and test case to reflect reality
better.
llvm-svn: 257723
Diffstat (limited to 'llvm/lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp')
-rw-r--r-- | llvm/lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/llvm/lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp b/llvm/lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp index 7a5c4f3136a..f3b871704d6 100644 --- a/llvm/lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp +++ b/llvm/lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp @@ -210,12 +210,10 @@ void WinCodeViewLineTables::emitDebugInfoForFunction(const Function *GV) { if (auto *SP = getDISubprogram(GV)) FuncName = SP->getDisplayName(); - // FIXME Clang currently sets DisplayName to "bar" for a C++ - // "namespace_foo::bar" function, see PR21528. Luckily, dbghelp.dll is trying - // to demangle display names anyways, so let's just put a mangled name into - // the symbols subsection until Clang gives us what we need. + // If our DISubprogram name is empty, use the mangled name. if (FuncName.empty()) FuncName = GlobalValue::getRealLinkageName(GV->getName()); + // Emit a symbol subsection, required by VS2012+ to find function boundaries. MCSymbol *SymbolsBegin = Asm->MMI->getContext().createTempSymbol(), *SymbolsEnd = Asm->MMI->getContext().createTempSymbol(); |