summaryrefslogtreecommitdiffstats
path: root/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
diff options
context:
space:
mode:
authorJeremy Morse <jeremy.morse.llvm@gmail.com>2019-10-15 10:46:24 +0000
committerJeremy Morse <jeremy.morse.llvm@gmail.com>2019-10-15 10:46:24 +0000
commited29dbaafa49bb8c9039a35f768244c394411fea (patch)
tree32dfe72ba734aa9f8e8f53c9ce9e58c232632884 /llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
parent4706f3be88d9cb530afb32b8d9d2bd5bfde2c881 (diff)
downloadbcm5719-llvm-ed29dbaafa49bb8c9039a35f768244c394411fea.tar.gz
bcm5719-llvm-ed29dbaafa49bb8c9039a35f768244c394411fea.zip
[DebugInfo] Remove some users of DBG_VALUEs IsIndirect field
This patch kills off a significant user of the "IsIndirect" field of DBG_VALUE machine insts. Brought up in in PR41675, IsIndirect is techncally redundant as it can be expressed by the DIExpression of a DBG_VALUE inst, and it isn't helpful to have two ways of expressing things. Rather than setting IsIndirect, have DBG_VALUE creators add an extra deref to the insts DIExpression. There should now be no appearences of IsIndirect=True from isel down to LiveDebugVariables / VirtRegRewriter, which is ensured by an assertion in LDVImpl::handleDebugValue. This means we also get to delete the IsIndirect handling in LiveDebugVariables. Tests can be upgraded by for example swapping the following IsIndirect=True DBG_VALUE: DBG_VALUE $somereg, 0, !123, !DIExpression(DW_OP_foo) With one where the indirection is in the DIExpression, by _appending_ a deref: DBG_VALUE $somereg, $noreg, !123, !DIExpression(DW_OP_foo, DW_OP_deref) Which both mean the same thing. Most of the test changes in this patch are updates of that form; also some changes in how the textual assembly printer handles these insts. Differential Revision: https://reviews.llvm.org/D68945 llvm-svn: 374877
Diffstat (limited to 'llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud