diff options
author | David Blaikie <dblaikie@gmail.com> | 2019-04-24 18:09:44 +0000 |
---|---|---|
committer | David Blaikie <dblaikie@gmail.com> | 2019-04-24 18:09:44 +0000 |
commit | 832c7d9f36bcb7a99113999439c82390b31919bd (patch) | |
tree | 18f7ebee245559d04318d5e3fa543cd8f77f4314 /llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp | |
parent | 882ca6d48483938bd1f3b42c279f9aa8364149a7 (diff) | |
download | bcm5719-llvm-832c7d9f36bcb7a99113999439c82390b31919bd.tar.gz bcm5719-llvm-832c7d9f36bcb7a99113999439c82390b31919bd.zip |
DebugInfo: Emit only declarations (not whole definitions) of non-unit user defined types into type units
While this doesn't come up in reasonable cases currently (the only user
defined types not in type units are ones without linkage - which makes
for near-ODR violations, because it'd be a type with linkage referencing
a type without linkage - such a type can't be validly defined in more
than one TU, so arguably it shouldn't be in a type unit to begin with -
but it's a convenient way to demonstrate an issue that will become more
revalent with homed modular debug info type definitions - which also
don't need to be in type units but more legitimately so).
Precursor to the Clang change to de-type-unit (by omitting the
'identifier') types homed due to strong linkage vtables. (making that
change without this one would lead to major type duplication in type
units)
llvm-svn: 359122
Diffstat (limited to 'llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp')
-rw-r--r-- | llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp index 0a06dfdae06..d6e8ae1590a 100644 --- a/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp +++ b/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp @@ -1201,6 +1201,10 @@ bool DwarfCompileUnit::isDwoUnit() const { return DD->useSplitDwarf() && Skeleton; } +void DwarfCompileUnit::finishNonUnitTypeDIE(DIE& D, const DICompositeType *CTy) { + constructTypeDIE(D, CTy); +} + bool DwarfCompileUnit::includeMinimalInlineScopes() const { return getCUNode()->getEmissionKind() == DICompileUnit::LineTablesOnly || (DD->useSplitDwarf() && !Skeleton); |