summaryrefslogtreecommitdiffstats
path: root/llvm/lib/CodeGen/AsmPrinter/DIEHash.cpp
diff options
context:
space:
mode:
authorReid Kleckner <rnk@google.com>2017-05-23 18:23:59 +0000
committerReid Kleckner <rnk@google.com>2017-05-23 18:23:59 +0000
commitded38803c5c5885b790b58ad93c4d9e981da8db8 (patch)
treeb045a713db43f8568ab5990e541e6e1ca0004f5e /llvm/lib/CodeGen/AsmPrinter/DIEHash.cpp
parent15288da29331e1ea49ebba445b7c2f694ee7ced3 (diff)
downloadbcm5719-llvm-ded38803c5c5885b790b58ad93c4d9e981da8db8.tar.gz
bcm5719-llvm-ded38803c5c5885b790b58ad93c4d9e981da8db8.zip
[PDB] Hash types up front when merging types instead of using StringMap
Summary: First, StringMap uses llvm::HashString, which is only good for short identifiers and really bad for large blobs of binary data like type records. Moving to `DenseMap<StringRef, TypeIndex>` with some tricks for memory allocation fixes that. Unfortunately, that didn't buy very much performance. Profiling showed that we spend a long time during DenseMap growth rehashing existing entries. Also, in general, DenseMap is faster when the keys are small. This change takes that to the logical conclusion by introducing a small wrapper value type around a pointer to key data. The key data contains a precomputed hash, the original record data (pointer and size), and the type index, which is the "value" of our original map. This reduces the time to produce llvm-as.exe and llvm-as.pdb from ~15s on my machine to 3.5s, which is about a 4x improvement. Reviewers: zturner, inglorion, ruiu Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D33428 llvm-svn: 303665
Diffstat (limited to 'llvm/lib/CodeGen/AsmPrinter/DIEHash.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud