diff options
author | Filipe Cabecinhas <me@filcab.net> | 2015-06-06 20:44:53 +0000 |
---|---|---|
committer | Filipe Cabecinhas <me@filcab.net> | 2015-06-06 20:44:53 +0000 |
commit | a911af0e8cbe751c816211acceb7adf0f6180fa4 (patch) | |
tree | be873b45a9358de29eb2fe9e2641e96f2c0bb1a6 /llvm/lib/Bitcode | |
parent | 1c8c213529e08e82c26548199f13bfebe42900af (diff) | |
download | bcm5719-llvm-a911af0e8cbe751c816211acceb7adf0f6180fa4.tar.gz bcm5719-llvm-a911af0e8cbe751c816211acceb7adf0f6180fa4.zip |
Use early return idiom. NFC
llvm-svn: 239228
Diffstat (limited to 'llvm/lib/Bitcode')
-rw-r--r-- | llvm/lib/Bitcode/Reader/BitcodeReader.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp index 75b3b9fd73c..056d87beef1 100644 --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp @@ -2065,13 +2065,13 @@ std::error_code BitcodeReader::ResolveGlobalAndAliasInits() { if (ValID >= ValueList.size()) { AliasInits.push_back(AliasInitWorklist.back()); } else { - if (Constant *C = dyn_cast_or_null<Constant>(ValueList[ValID])) { - GlobalAlias *Alias = AliasInitWorklist.back().first; - if (C->getType() != Alias->getType()) - return Error("Alias and aliasee types don't match"); - Alias->setAliasee(C); - } else + Constant *C = dyn_cast_or_null<Constant>(ValueList[ValID]); + if (!C) return Error("Expected a constant"); + GlobalAlias *Alias = AliasInitWorklist.back().first; + if (C->getType() != Alias->getType()) + return Error("Alias and aliasee types don't match"); + Alias->setAliasee(C); } AliasInitWorklist.pop_back(); } |