summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
diff options
context:
space:
mode:
authorDuncan Sands <baldrick@free.fr>2012-05-08 12:16:05 +0000
committerDuncan Sands <baldrick@free.fr>2012-05-08 12:16:05 +0000
commit3bbb1d50df60340d5eac9384b7140db29fcf9e51 (patch)
tree40b2329b4f5709fcb4c2087590677d7263fdd59e /llvm/lib/Bitcode/Reader/BitcodeReader.cpp
parent5eafce5c88152dc4a281bd40b92d4525c9df1976 (diff)
downloadbcm5719-llvm-3bbb1d50df60340d5eac9384b7140db29fcf9e51.tar.gz
bcm5719-llvm-3bbb1d50df60340d5eac9384b7140db29fcf9e51.zip
Calling ReassociateExpression recursively is extremely dangerous since it will
replace the operands of expressions with only one use with undef and generate a new expression for the original without using RAUW to update the original. Thus any copies of the original expression held in a vector may end up referring to some bogus value - and using a ValueHandle won't help since there is no RAUW. There is already a mechanism for getting the effect of recursion non-recursively: adding the value to be recursed on to RedoInsts. But it wasn't being used systematically. Have various places where recursion had snuck in at some point use the RedoInsts mechanism instead. Fixes PR12169. llvm-svn: 156379
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud