summaryrefslogtreecommitdiffstats
path: root/llvm/lib/BinaryFormat/AMDGPUMetadataVerifier.cpp
diff options
context:
space:
mode:
authorAnastasia Stulova <anastasia.stulova@arm.com>2019-05-08 14:23:49 +0000
committerAnastasia Stulova <anastasia.stulova@arm.com>2019-05-08 14:23:49 +0000
commit5b6dda33d1227e9f9c2a3ec8464a7ddd90df45d2 (patch)
treedeada0ef5812e1c9a664c0ee76b2972e28f627f1 /llvm/lib/BinaryFormat/AMDGPUMetadataVerifier.cpp
parent4ba5269f33ffd7252125d831418316e9f9e3b4a6 (diff)
downloadbcm5719-llvm-5b6dda33d1227e9f9c2a3ec8464a7ddd90df45d2.tar.gz
bcm5719-llvm-5b6dda33d1227e9f9c2a3ec8464a7ddd90df45d2.zip
[Sema][OpenCL] Make address space conversions a bit stricter.
The semantics for converting nested pointers between address spaces are not very well defined. Some conversions which do not really carry any meaning only produce warnings, and in some cases warnings hide invalid conversions, such as 'global int*' to 'local float*'! This patch changes the logic in checkPointerTypesForAssignment and checkAddressSpaceCast to fail properly on implicit conversions that should definitely not be permitted. We also dig deeper into the pointer types and warn on explicit conversions where the address space in a nested pointer changes, regardless of whether the address space is compatible with the corresponding pointer nesting level on the destination type. Fixes PR39674! Patch by ebevhan (Bevin Hansson)! Differential Revision: https://reviews.llvm.org/D58236 llvm-svn: 360258
Diffstat (limited to 'llvm/lib/BinaryFormat/AMDGPUMetadataVerifier.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud