diff options
author | Chris Lattner <sabre@nondot.org> | 2009-01-05 18:34:07 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2009-01-05 18:34:07 +0000 |
commit | 2ed06b4276d001e3b2d80c0524a9c069852e3232 (patch) | |
tree | 56dcd4f6a7ad6478ab2a0feb547ce30a7c5e2e93 /llvm/lib/AsmParser | |
parent | 758e7d778186a426b5169ac78af2e134e4b1539c (diff) | |
download | bcm5719-llvm-2ed06b4276d001e3b2d80c0524a9c069852e3232.tar.gz bcm5719-llvm-2ed06b4276d001e3b2d80c0524a9c069852e3232.zip |
Reject PR3281:accepted03.ll with:
llvm-as: accepted03.ll:1:35: invalid unresolved type up reference
declare void @r({ \7, opaque, \10 } %su)
^
llvm-svn: 61725
Diffstat (limited to 'llvm/lib/AsmParser')
-rw-r--r-- | llvm/lib/AsmParser/LLParser.cpp | 15 | ||||
-rw-r--r-- | llvm/lib/AsmParser/LLParser.h | 2 |
2 files changed, 11 insertions, 6 deletions
diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp index a9f8e192d38..0708b798ada 100644 --- a/llvm/lib/AsmParser/LLParser.cpp +++ b/llvm/lib/AsmParser/LLParser.cpp @@ -1075,15 +1075,17 @@ bool LLParser::ParseParameterList(SmallVectorImpl<ParamInfo> &ArgList, -/// ParseArgumentList +/// ParseArgumentList - Parse the argument list for a function type or function +/// prototype. If 'inType' is true then we are parsing a FunctionType. /// ::= '(' ArgTypeListI ')' /// ArgTypeListI /// ::= /*empty*/ /// ::= '...' /// ::= ArgTypeList ',' '...' /// ::= ArgType (',' ArgType)* +/// bool LLParser::ParseArgumentList(std::vector<ArgInfo> &ArgList, - bool &isVarArg) { + bool &isVarArg, bool inType) { isVarArg = false; assert(Lex.getKind() == lltok::lparen); Lex.Lex(); // eat the (. @@ -1099,7 +1101,10 @@ bool LLParser::ParseArgumentList(std::vector<ArgInfo> &ArgList, unsigned Attrs; std::string Name; - if (ParseTypeRec(ArgTy) || + // If we're parsing a type, use ParseTypeRec, because we allow recursive + // types (such as a function returning a pointer to itself). If parsing a + // function prototype, we require fully resolved types. + if ((inType ? ParseTypeRec(ArgTy) : ParseType(ArgTy)) || ParseOptionalAttrs(Attrs, 0)) return true; if (Lex.getKind() == lltok::LocalVar || @@ -1154,7 +1159,7 @@ bool LLParser::ParseFunctionType(PATypeHolder &Result) { std::vector<ArgInfo> ArgList; bool isVarArg; unsigned Attrs; - if (ParseArgumentList(ArgList, isVarArg) || + if (ParseArgumentList(ArgList, isVarArg, true) || // FIXME: Allow, but ignore attributes on function types! // FIXME: Remove in LLVM 3.0 ParseOptionalAttrs(Attrs, 2)) @@ -2087,7 +2092,7 @@ bool LLParser::ParseFunctionHeader(Function *&Fn, bool isDefine) { unsigned Alignment; std::string GC; - if (ParseArgumentList(ArgList, isVarArg) || + if (ParseArgumentList(ArgList, isVarArg, false) || ParseOptionalAttrs(FuncAttrs, 2) || (EatIfPresent(lltok::kw_section) && ParseStringConstant(Section)) || diff --git a/llvm/lib/AsmParser/LLParser.h b/llvm/lib/AsmParser/LLParser.h index f2c3187e9ef..f013c630df8 100644 --- a/llvm/lib/AsmParser/LLParser.h +++ b/llvm/lib/AsmParser/LLParser.h @@ -232,7 +232,7 @@ namespace llvm { : Loc(L), Type(Ty), Attrs(Attr), Name(N) {} }; bool ParseArgumentList(std::vector<ArgInfo> &ArgList, - bool &isVarArg); + bool &isVarArg, bool inType); bool ParseFunctionHeader(Function *&Fn, bool isDefine); bool ParseFunctionBody(Function &Fn); bool ParseBasicBlock(PerFunctionState &PFS); |