diff options
author | Brian Gesiak <modocache@gmail.com> | 2017-06-30 23:14:53 +0000 |
---|---|---|
committer | Brian Gesiak <modocache@gmail.com> | 2017-06-30 23:14:53 +0000 |
commit | 4ef3daafef7c53d03bd221a323d34ae2cd47d14d (patch) | |
tree | 4fad026658b6f904209da704a666f75f6a0ca41a /llvm/lib/Analysis | |
parent | 4fcfc19976c9abfb98008f67c973b99376580121 (diff) | |
download | bcm5719-llvm-4ef3daafef7c53d03bd221a323d34ae2cd47d14d.tar.gz bcm5719-llvm-4ef3daafef7c53d03bd221a323d34ae2cd47d14d.zip |
[ORE] Add diagnostics hotness threshold
Summary:
Add an option to prevent diagnostics that do not meet a minimum hotness
threshold from being output. When generating optimization remarks for
large codebases with a ton of cold code paths, this option can be used
to limit the optimization remark output at a reasonable size. Discussion of
this change can be read here:
http://lists.llvm.org/pipermail/llvm-dev/2017-June/114377.html
Reviewers: anemet, davidxl, hfinkel
Reviewed By: anemet
Subscribers: qcolombet, javed.absar, fhahn, eraman, llvm-commits
Differential Revision: https://reviews.llvm.org/D34867
llvm-svn: 306912
Diffstat (limited to 'llvm/lib/Analysis')
-rw-r--r-- | llvm/lib/Analysis/OptimizationDiagnosticInfo.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/llvm/lib/Analysis/OptimizationDiagnosticInfo.cpp b/llvm/lib/Analysis/OptimizationDiagnosticInfo.cpp index e1650040880..eb259fd7a38 100644 --- a/llvm/lib/Analysis/OptimizationDiagnosticInfo.cpp +++ b/llvm/lib/Analysis/OptimizationDiagnosticInfo.cpp @@ -155,6 +155,13 @@ void OptimizationRemarkEmitter::emit( DiagnosticInfoOptimizationBase &OptDiagBase) { auto &OptDiag = cast<DiagnosticInfoIROptimization>(OptDiagBase); computeHotness(OptDiag); + // If a diagnostic has a hotness value, then only emit it if its hotness + // meets the threshold. + if (OptDiag.getHotness() && + *OptDiag.getHotness() < + F->getContext().getDiagnosticsHotnessThreshold()) { + return; + } yaml::Output *Out = F->getContext().getDiagnosticsOutputFile(); if (Out) { |