summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Analysis/ValueTracking.cpp
diff options
context:
space:
mode:
authorPeter Zotov <whitequark@whitequark.org>2016-04-03 12:30:46 +0000
committerPeter Zotov <whitequark@whitequark.org>2016-04-03 12:30:46 +0000
commit0218d0f38355624acbe4960170a97fb67f5af779 (patch)
tree928453f095dee8da0ab01fc75834339169726eaf /llvm/lib/Analysis/ValueTracking.cpp
parent2075b5d2a122a3790c05ce12941a738da1a8b205 (diff)
downloadbcm5719-llvm-0218d0f38355624acbe4960170a97fb67f5af779.tar.gz
bcm5719-llvm-0218d0f38355624acbe4960170a97fb67f5af779.zip
Mark some FP intrinsics as safe to speculatively execute
Floating point intrinsics in LLVM are generally not speculatively executed, since most of them are defined to behave the same as libm functions, which set errno. However, the only error that can happen when executing ceil, floor, nearbyint, rint and round libm functions per POSIX.1-2001 is -ERANGE, and that requires the maximum value of the exponent to be smaller than the number of mantissa bits, which is not the case with any of the floating point types supported by LLVM. The trunc and copysign functions never set errno per per POSIX.1-2001. Differential Revision: http://reviews.llvm.org/D18643 llvm-svn: 265262
Diffstat (limited to 'llvm/lib/Analysis/ValueTracking.cpp')
-rw-r--r--llvm/lib/Analysis/ValueTracking.cpp20
1 files changed, 16 insertions, 4 deletions
diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp
index 802bc117495..144ec63c931 100644
--- a/llvm/lib/Analysis/ValueTracking.cpp
+++ b/llvm/lib/Analysis/ValueTracking.cpp
@@ -2989,17 +2989,29 @@ bool llvm::isSafeToSpeculativelyExecute(const Value *V,
case Intrinsic::umul_with_overflow:
case Intrinsic::usub_with_overflow:
return true;
- // Sqrt should be OK, since the llvm sqrt intrinsic isn't defined to set
- // errno like libm sqrt would.
+ // These intrinsics are defined to have the same behavior as libm
+ // functions except for setting errno.
case Intrinsic::sqrt:
case Intrinsic::fma:
case Intrinsic::fmuladd:
+ return true;
+ // These intrinsics are defined to have the same behavior as libm
+ // functions, and the corresponding libm functions never set errno.
+ case Intrinsic::trunc:
+ case Intrinsic::copysign:
case Intrinsic::fabs:
case Intrinsic::minnum:
case Intrinsic::maxnum:
return true;
- // TODO: some fp intrinsics are marked as having the same error handling
- // as libm. They're safe to speculate when they won't error.
+ // These intrinsics are defined to have the same behavior as libm
+ // functions, which never overflow when operating on the IEEE754 types
+ // that we support, and never set errno otherwise.
+ case Intrinsic::ceil:
+ case Intrinsic::floor:
+ case Intrinsic::nearbyint:
+ case Intrinsic::rint:
+ case Intrinsic::round:
+ return true;
// TODO: are convert_{from,to}_fp16 safe?
// TODO: can we list target-specific intrinsics here?
default: break;
OpenPOWER on IntegriCloud