diff options
| author | Dehao Chen <dehao@google.com> | 2017-07-07 21:01:00 +0000 |
|---|---|---|
| committer | Dehao Chen <dehao@google.com> | 2017-07-07 21:01:00 +0000 |
| commit | 64c46574b0adc5aece427650a0b950a3eb3e166e (patch) | |
| tree | 203a5d389f9112aa7bed901b4f67b505d9a94b30 /llvm/lib/Analysis/ModuleSummaryAnalysis.cpp | |
| parent | 4a7e66a84686f07b525adc90b97ea6f24ae86e00 (diff) | |
| download | bcm5719-llvm-64c46574b0adc5aece427650a0b950a3eb3e166e.tar.gz bcm5719-llvm-64c46574b0adc5aece427650a0b950a3eb3e166e.zip | |
Increase the import-threshold for crtical functions.
Summary: For interative sample-pgo, if a hot call site is inlined in the profiling binary, we should inline it in before profile annotation in the backend. Before that, the compile phase first collects all GUIDs that needs to be imported and creates virtual "hot" call edge in the summary. However, "hot" is not good enough to guarantee the callsites get inlined. This patch introduces "critical" call edge, and assign much higher importing threshold for those edges.
Reviewers: tejohnson
Reviewed By: tejohnson
Subscribers: sanjoy, mehdi_amini, llvm-commits, eraman
Differential Revision: https://reviews.llvm.org/D35096
llvm-svn: 307439
Diffstat (limited to 'llvm/lib/Analysis/ModuleSummaryAnalysis.cpp')
| -rw-r--r-- | llvm/lib/Analysis/ModuleSummaryAnalysis.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp b/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp index 095647e1bd2..e9e354ebb88 100644 --- a/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp +++ b/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp @@ -266,7 +266,7 @@ computeFunctionSummary(ModuleSummaryIndex &Index, const Module &M, // sample PGO, to enable the same inlines as the profiled optimized binary. for (auto &I : F.getImportGUIDs()) CallGraphEdges[Index.getOrInsertValueInfo(I)].updateHotness( - CalleeInfo::HotnessType::Hot); + CalleeInfo::HotnessType::Critical); bool NonRenamableLocal = isNonRenamableLocal(F); bool NotEligibleForImport = |
