diff options
author | George Rimar <grimar@accesssoftek.com> | 2017-08-22 08:50:56 +0000 |
---|---|---|
committer | George Rimar <grimar@accesssoftek.com> | 2017-08-22 08:50:56 +0000 |
commit | 1e94ca115d014500df6f6cc920d58d6746043eb1 (patch) | |
tree | 5b62d11db59b6c42557a58f6c6d8f96214d1088c /llvm/lib/Analysis/ModuleSummaryAnalysis.cpp | |
parent | 3a1af22099f8193c077ba594d78482daa39ca3fa (diff) | |
download | bcm5719-llvm-1e94ca115d014500df6f6cc920d58d6746043eb1.tar.gz bcm5719-llvm-1e94ca115d014500df6f6cc920d58d6746043eb1.zip |
[lib/Analysis] - Mark personality functions as live.
This is PR33245.
Case I am fixing is next:
Imagine we have 2 BC files, one defines and uses personality routine,
second has only declaration and also uses it.
Previously algorithm computing dead symbols (llvm::computeDeadSymbols) did
not know about personality routines and leaved them dead even if function that
has routine was live.
As a result thinLTOInternalizeAndPromoteGUID() method changed binding for
such symbol to local. Later when LLD tried to link these objects it failed
because one object had undefined global symbol for routine and second
object contained local definition instead of global.
Patch set the live root flag on the corresponding FunctionSummary
for personality routines when we build the per-module summaries
during the compile step.
Differential revision: https://reviews.llvm.org/D36834
llvm-svn: 311432
Diffstat (limited to 'llvm/lib/Analysis/ModuleSummaryAnalysis.cpp')
-rw-r--r-- | llvm/lib/Analysis/ModuleSummaryAnalysis.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp b/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp index cb735562fa6..886dac8314e 100644 --- a/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp +++ b/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp @@ -403,6 +403,12 @@ ModuleSummaryIndex llvm::buildModuleSummaryIndex( CantBePromoted); } + // Set live flag for all personality functions. That allows to + // preserve them during DCE. + for (const llvm::Function &F : M) + if (!F.isDeclaration() && F.hasPersonalityFn()) + setLiveRoot(Index, F.getPersonalityFn()->getName()); + // Compute summaries for all variables defined in module, and save in the // index. for (const GlobalVariable &G : M.globals()) { |