diff options
author | Chris Lattner <sabre@nondot.org> | 2009-11-23 17:07:35 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2009-11-23 17:07:35 +0000 |
commit | 214ef9a4ef386ecde0335709e4fcdfeb105c52b7 (patch) | |
tree | e8d7eb8db0f0ee607756f60b850de66aa06cb639 /llvm/lib/Analysis/BasicAliasAnalysis.cpp | |
parent | 1e7b37ebba68b7fe0bb36b039096ff6c78e6e31f (diff) | |
download | bcm5719-llvm-214ef9a4ef386ecde0335709e4fcdfeb105c52b7.tar.gz bcm5719-llvm-214ef9a4ef386ecde0335709e4fcdfeb105c52b7.zip |
fix comment, thanks all :)
llvm-svn: 89666
Diffstat (limited to 'llvm/lib/Analysis/BasicAliasAnalysis.cpp')
-rw-r--r-- | llvm/lib/Analysis/BasicAliasAnalysis.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/llvm/lib/Analysis/BasicAliasAnalysis.cpp b/llvm/lib/Analysis/BasicAliasAnalysis.cpp index 32ca9111c26..ff65e33ad50 100644 --- a/llvm/lib/Analysis/BasicAliasAnalysis.cpp +++ b/llvm/lib/Analysis/BasicAliasAnalysis.cpp @@ -263,7 +263,9 @@ ImmutablePass *llvm::createBasicAliasAnalysisPass() { bool BasicAliasAnalysis::pointsToConstantMemory(const Value *P) { if (const GlobalVariable *GV = dyn_cast<GlobalVariable>(P->getUnderlyingObject())) - // FIXME: shouldn't this require GV to be "ODR"? + // Note: this doesn't require GV to be "ODR" because it isn't legal for a + // global to be marked constant in some modules and non-constant in others. + // GV may even be a declaration, not a definition. return GV->isConstant(); return false; } |