diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2016-11-04 07:16:33 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2016-11-04 07:16:33 +0000 |
| commit | 8a5170e02a415ed85cf60daf8434308526d14f61 (patch) | |
| tree | d5ae8d85022ae9bbe1463a638c36dd5748b02ba1 /llvm/include | |
| parent | 33e58901db5d1a1fc8e3b7d99710f96634e3ae92 (diff) | |
| download | bcm5719-llvm-8a5170e02a415ed85cf60daf8434308526d14f61.tar.gz bcm5719-llvm-8a5170e02a415ed85cf60daf8434308526d14f61.zip | |
Add a missing return to the move assignment operator for
SequenceNumberManager.
Sadly, we don't have any unittests for this class because it is
a private class. Since it seems to have a nice isolated and testable
interface, it'd be great to extract it to a detail namespace and write
unit tests for it as then we could catch issues. I'll probably pester
Lang about that or some alternative refactoring.
This was noticed by PVS-Studio.
llvm-svn: 285990
Diffstat (limited to 'llvm/include')
| -rw-r--r-- | llvm/include/llvm/ExecutionEngine/Orc/RPCUtils.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/RPCUtils.h b/llvm/include/llvm/ExecutionEngine/Orc/RPCUtils.h index b6c7b2e7bbc..436c037e920 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/RPCUtils.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/RPCUtils.h @@ -700,6 +700,7 @@ private: SequenceNumberManager &operator=(SequenceNumberManager &&Other) { NextSequenceNumber = std::move(Other.NextSequenceNumber); FreeSequenceNumbers = std::move(Other.FreeSequenceNumbers); + return *this; } void reset() { |

